Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19911
Thank you all and sorry for the distraction due to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19911
@danielvdende Thanks for your contributions!
LGTM
Merged to master.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19911
**[Test build #4007 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4007/testReport)**
for PR 19911 at commit
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
@srowen Sorry, should have been clearer, I meant the triggering of the
tests (I see they're running now, thanks! )
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19911
**[Test build #4007 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4007/testReport)**
for PR 19911 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19911
@danielvdende test don't pass yet. I've retriggered them. I don't see a
particularly long response cycle here.
---
-
To
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
Forgive my impatience, but is it supposed to take this long? @dongjoon-hyun
@gatorsmile
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19911
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19911
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84702/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19911
**[Test build #84702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84702/testReport)**
for PR 19911 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19911
**[Test build #84702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84702/testReport)**
for PR 19911 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19911
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
@dongjoon-hyun @gatorsmile As @gatorsmile pointed out, the
`isCascadingTruncateTable` is a method in the public API, so we can't just drop
it. I've made changes again, now the truncate query
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
@dongjoon-hyun ok made the changes, also replaced the test that was in
place for `isCascadingTruncateTable` with one for the `getTruncateQuery`
method. Right now, I've left the method in
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
@dongjoon-hyun I was considering this. Wanted to hear your opinion on it
first ;-). I'll make those changes.
---
-
To
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19911
@danielvdende . I think your PR is able to replace the old way completely.
Could you try the followings?
1. Remove the old `isCascadingTruncateTable` from all Jdbc dialects.
2.
Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
@dongjoon-hyun I've addressed the issues you mentioned :)
---
-
To unsubscribe, e-mail:
20 matches
Mail list logo
