Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22328
Merged into master. Thanks @WeichenXu123 for the implementation and
everyone for the review! I created the following JIRAs as follow-ups:
* deprecate ImageSchema:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95727/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95727 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95727/testReport)**
for PR 22328 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95727 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95727/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22328
The image data source tests passed but JVM crashed at the end. Triggered
another test.
---
-
To unsubscribe, e-mail:
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22328
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95724/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95724 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95724/testReport)**
for PR 22328 at commit
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22328
LGTM pending tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95724 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95724/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95715/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95715/testReport)**
for PR 22328 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95715/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95707/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95707 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95707/testReport)**
for PR 22328 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95707 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95707/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95694/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95694/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95695/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95695/testReport)**
for PR 22328 at commit
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22328
That doesn't work for Java, if I remember the issue correctly.
On Tue, Sep 4, 2018, 10:31 PM Wenchen Fan wrote:
> *@cloud-fan* commented on this pull request.
>
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95695/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95694/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22328
@mhamilton723 I thought about that option too. Loading general binary files
is a useful feature but I don't feel it is necessary to pull it into the
current scope. No matter whether the image data
Github user mhamilton723 commented on the issue:
https://github.com/apache/spark/pull/22328
@WeichenXu123. Awesome work! I have not had a chance to go through this in
depth but I did this in the originating project, [MMLSpark](www.aka.ms/spark),
a while back and have been meaning to
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/22328
@mhamilton723 could you take a look at this PR? Mark added some
performance improvements in MMLSpark that we wanted to merge in and he also
added support for streaming (this was one of the
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22328
Yes, the ImageSchema implementation are used by the data source, which we
cannot remove:) We are only going to mark the public APIs there as deprecated.
The goal is to provide users a unified
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/22328
I don't think you need duplicate images in the PR - in the old tests you
can just specify the path up to the cls/date folder. There might be a few
minor changes to the tests but I think that
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/22328
@mengxr "is to mark ImageSchema deprecated in 2.4 and remove it in 3.0"
confused, this is still using ImageSchema though, right? You mean to
remove the top-level readImages API, but the
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/22328
"specify numPartitions (it will be determined by datasource automatically)"
This feature was because of this bug:
https://issues.apache.org/jira/browse/SPARK-22357
Which
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22328
@imatiach-msft @HyukjinKwon The plan is to mark `ImageSchema` deprecated in
2.4 and remove it in 3.0. So loading images will be the same as loading data
from other sources.
The gaps are
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/22328
question: why were the images renamed to images/images folder from just
images? Seems a bit strange to me to have the same folder name twice.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95668/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95668 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95668/testReport)**
for PR 22328 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95668/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22328
cc @imatiach-msft
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95667/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95667 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95667/testReport)**
for PR 22328 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95667 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95667/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
63 matches
Mail list logo
