Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11568
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-195006855
(BTW I'll fix the title during merge since this is not a sql change.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-195006609
Ok, merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194663608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194663605
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194663017
**[Test build #52808 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52808/consoleFull)**
for PR 11568 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194659161
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194659162
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194659015
**[Test build #52803 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52803/consoleFull)**
for PR 11568 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194644473
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194627656
**[Test build #52808 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52808/consoleFull)**
for PR 11568 at commit
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194627352
Made some changes based on @andrewor14 comments. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194618069
**[Test build #52803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52803/consoleFull)**
for PR 11568 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55624429
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,13 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-194617476
ok to test @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-193968072
@srowen thanks for the suggestion. i've pushed the changes to make it more
concise.
---
If your project is set up for it, you can reply to this email and have your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55424521
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,13 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55419451
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55418220
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-193939241
@jaceklaskowski @srowen I've some changes. How about the logic this time?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55413797
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55409812
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55408473
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55407249
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55406003
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11568#issuecomment-193527447
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user bomeng opened a pull request:
https://github.com/apache/spark/pull/11568
[SPARK-13727] [SQL] SparkConf.contains does not consider deprecated keys
## What changes were proposed in this pull request?
The contains() method does not return consistently with get() if the
27 matches
Mail list logo
