Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12718#discussion_r61527726
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -79,11 +79,12 @@ final class ChiSqSelector(override val uid:
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12718#issuecomment-215550190
Other than the few places where you could use symbols not string literals
LGTM. Excellent job! Thanks.
---
If your project is set up for it, you can reply to
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12718#discussion_r61494448
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -79,11 +79,12 @@ final class ChiSqSelector(override val uid:
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/12718#issuecomment-215437825
@jkbradley @mengxr @jaceklaskowski The new `Dataset.as` API is appled to ML
in this PR.
---
If your project is set up for it, you can reply to this email and
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/12718#issuecomment-215425031
@viirya Thanks. I updated this PR following your example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
