[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13368#issuecomment-222596139 cc @yhuai @davies , do you still remember why we promote string to decimal(38, 18) instead of double? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-27 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13368#discussion_r64982756 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -290,11 +290,6 @@ object TypeCoercion {

[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-27 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13368#discussion_r64981737 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -290,11 +290,6 @@ object TypeCoercion {

[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13368#issuecomment-82415 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13368#issuecomment-82416 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13368#issuecomment-82364 **[Test build #59537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59537/consoleFull)** for PR 13368 at commit

[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13368#discussion_r64979724 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -290,11 +290,6 @@ object TypeCoercion {

[GitHub] spark pull request: [SPARK-15557][SQL] expressi[on ((cast(99 as de...

2016-05-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13368#issuecomment-75505 **[Test build #59537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59537/consoleFull)** for PR 13368 at commit