Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65136606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -937,8 +937,12 @@ object SimplifyConditionals
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222604482
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222604484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222604316
**[Test build #59636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59636/consoleFull)**
for PR 13392 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222601745
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222601744
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222601564
**[Test build #59634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59634/consoleFull)**
for PR 13392 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-22259
**[Test build #59636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59636/consoleFull)**
for PR 13392 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65124178
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -219,4 +220,41 @@ class SQLConfSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65124192
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -219,4 +220,41 @@ class SQLConfSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65123693
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -219,4 +220,41 @@ class SQLConfSuite extends QueryTest with
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222592448
LGTM except some style comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65123624
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -219,4 +220,41 @@ class SQLConfSuite extends QueryTest with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222592083
**[Test build #59634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59634/consoleFull)**
for PR 13392 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65122900
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -17,13 +17,36 @@
package
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65122821
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -17,13 +17,36 @@
package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65121914
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -937,9 +937,14 @@ object SimplifyConditionals
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65121902
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -17,13 +17,36 @@
package
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65120800
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -17,13 +17,36 @@
package
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65120442
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -937,9 +937,14 @@ object SimplifyConditionals
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222574008
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222574005
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222573920
**[Test build #59626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59626/consoleFull)**
for PR 13392 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222571769
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222571771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222571690
**[Test build #59623 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59623/consoleFull)**
for PR 13392 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222567824
**[Test build #59626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59626/consoleFull)**
for PR 13392 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222566016
**[Test build #59623 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59623/consoleFull)**
for PR 13392 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222565978
Sorry, pushed to a wrong branch. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65019806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -937,7 +937,8 @@ object SimplifyConditionals
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65008333
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -937,7 +937,8 @@ object SimplifyConditionals
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222362917
@dongjoon-hyun Yeah. As pointed out above, I knew it was not introduced by
your PR. Thanks!
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222349073
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222349072
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222349019
**[Test build #59585 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59585/consoleFull)**
for PR 13392 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222346595
Thank you for making me up-to-date, @gatorsmile !
By the way, there is one correction. My PR is about **parameterizing** the
following previous code. :)
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222346373
cc @cloud-fan @rxin Could you verify if my understanding is right? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222346333
@dongjoon-hyun FYI, this PR is just to fix the boundary cases. I knew this
issue was not introduced in your PR:
https://github.com/apache/spark/pull/12353. Thanks!
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13392#issuecomment-222346307
**[Test build #59585 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59585/consoleFull)**
for PR 13392 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/13392
[SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodegen Rule
What changes were proposed in this pull request?
The following condition in the Optimizer rule `OptimizeCodegen` is
40 matches
Mail list logo
