[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73053436 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1457,6 +1457,59 @@ class SQLQuerySuite extends

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73051607 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1457,6 +1457,59 @@ class SQLQuerySuite extends

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73048060 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -236,6 +236,11 @@ case class

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73048108 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1457,6 +1457,59 @@ class SQLQuerySuite extends

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73048087 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -449,6 +449,22 @@ class DataFrameReaderWriterSuite

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73047977 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -236,6 +236,11 @@ case class

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73035297 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1457,6 +1457,59 @@ class SQLQuerySuite extends

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73035235 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -449,6 +449,22 @@ class

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73034863 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -236,6 +236,11 @@ case class

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-08-01 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r73034796 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -236,6 +236,11 @@ case class

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-07-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r72880810 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -236,6 +236,11 @@ case class

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-07-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14410#discussion_r72880504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -236,6 +236,11 @@ case class

[GitHub] spark pull request #14410: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-07-29 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/14410 [SPARK-16803] [SQL] SaveAsTable does not work when source DataFrame is built on a Hive Table ### What changes were proposed in this pull request? In Spark 2.0, `SaveAsTable` does not work