[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87510311 --- Diff: R/create-docs.sh --- @@ -52,21 +52,28 @@ Rscript -e 'libDir <- "../../lib"; library(SparkR, lib.loc=libDir); library(knit popd

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87510242 --- Diff: R/check-cran.sh --- @@ -36,11 +36,27 @@ if [ ! -z "$R_HOME" ] fi echo "USING R_HOME = $R_HOME" -# Build the latest docs

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87510152 --- Diff: R/create-docs.sh --- @@ -52,21 +52,28 @@ Rscript -e 'libDir <- "../../lib"; library(SparkR, lib.loc=libDir); library(knit popd

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87510033 --- Diff: R/create-docs.sh --- @@ -52,21 +52,28 @@ Rscript -e 'libDir <- "../../lib"; library(SparkR, lib.loc=libDir); library(knit popd

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87509955 --- Diff: R/create-docs.sh --- @@ -52,21 +52,28 @@ Rscript -e 'libDir <- "../../lib"; library(SparkR, lib.loc=libDir); library(knit popd

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87509314 --- Diff: R/check-cran.sh --- @@ -36,11 +36,27 @@ if [ ! -z "$R_HOME" ] fi echo "USING R_HOME = $R_HOME" -# Build the latest docs

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87507979 --- Diff: R/create-docs.sh --- @@ -52,21 +52,28 @@ Rscript -e 'libDir <- "../../lib"; library(SparkR, lib.loc=libDir); library(knit popd

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87507839 --- Diff: R/run-tests.sh --- @@ -48,6 +48,7 @@ if [[ $FAILED != 0 || $NUM_TEST_WARNING != 0 ]]; then else # We have 2 existing NOTEs for new

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87507867 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -1,12 +1,13 @@ --- title: "SparkR - Practical Guide" output: - html_document:

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87504850 --- Diff: R/check-cran.sh --- @@ -36,11 +36,27 @@ if [ ! -z "$R_HOME" ] fi echo "USING R_HOME = $R_HOME" -# Build the latest docs

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87500577 --- Diff: R/check-cran.sh --- @@ -36,11 +36,27 @@ if [ ! -z "$R_HOME" ] fi echo "USING R_HOME = $R_HOME" -# Build the latest docs

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87499208 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -1,12 +1,13 @@ --- title: "SparkR - Practical Guide" output: - html_document:

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87448147 --- Diff: R/CRAN_RELEASE.md --- @@ -0,0 +1,74 @@ +# SparkR CRAN Release + +To release SparkR as a package to CRAN, we would use the `devtools`

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87448886 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -1,12 +1,13 @@ --- title: "SparkR - Practical Guide" output: - html_document:

[GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...

2016-11-08 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15790#discussion_r87048260 --- Diff: R/run-tests.sh --- @@ -48,7 +48,8 @@ if [[ $FAILED != 0 || $NUM_TEST_WARNING != 0 ]]; then else # We have 2 existing NOTEs for new