[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-03-15 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r106334932 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,105 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-03-15 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r106334083 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,105 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-03-15 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r106157856 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,105 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-23 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r102671021 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,105 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r102616898 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,105 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101770992 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101770685 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,104 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-17 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101770055 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-17 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101766864 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,104 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101690256 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101688665 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101688198 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,105 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101673768 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101516174 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,104 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101515786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101505199 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101478064 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101468470 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,104 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-16 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101466954 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101438354 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101436701 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +343,104 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r101436180 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-06 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r99753353 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -20,8 +20,12 @@ package

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-02-06 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r99535960 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,99 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r97796700 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,99 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r97793794 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -20,8 +20,12 @@ package

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-16 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r96348295 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-16 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r96347397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-16 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r96347281 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -17,11 +17,13 @@ package org.apache.spark.sql

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-16 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r96347166 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95732892 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95732577 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95721703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95720884 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95720330 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -17,11 +17,13 @@ package org.apache.spark.sql

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95720313 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -17,11 +17,13 @@ package org.apache.spark.sql

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95719439 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95719293 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95718514 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95718465 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +344,96 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95102912 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95102842 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95080770 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95080769 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95080738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95080582 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95080333 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95080295 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95079031 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-08 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95078909 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1528,6 +1528,18 @@ object functions { def factorial(e: Column): Column

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95060664 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95060633 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95060564 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95060448 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95060436 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95060369 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95060307 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054878 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95055535 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95055899 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95055160 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054994 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054951 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95055000 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95055681 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95055087 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95055050 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95055128 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054704 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054651 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054605 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054575 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054547 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054508 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95054387 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95023996 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala --- @@ -137,4 +139,48 @@ class

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95024068 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object CaseKeyWhen {

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95023960 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1528,6 +1528,18 @@ object functions { def factorial(e: Column): Column =

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-06 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r95023939 --- Diff: python/pyspark/sql/functions.py --- @@ -320,6 +320,22 @@ def countDistinct(col, *cols): return Column(jc) +@since(2.2)

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-05 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r94798265 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-05 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r94797482 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object

[GitHub] spark pull request #16476: [SPARK-19084][SQL] Implement expression field

2017-01-05 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/16476#discussion_r94796481 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -340,3 +341,91 @@ object