Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16652
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16652#discussion_r98516538
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -400,6 +400,17 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16652#discussion_r98435106
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -18,20 +18,26 @@
package
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16652#discussion_r97056877
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -18,20 +18,26 @@
package
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16652#discussion_r97057073
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -415,4 +421,40 @@ object AFTSurvivalRegressionSuite {
GitHub user admackin opened a pull request:
https://github.com/apache/spark/pull/16652
[SPARK-19234][MLLib] AFTSurvivalRegression should fail fast when any labels
are zero
## What changes were proposed in this pull request?
If any labels of 0.0 (which are invalid) are
