Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r152503817
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r152493744
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r152192733
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r152189670
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17436
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151828392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151765263
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala
---
@@ -260,6 +261,7 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151764870
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -62,7 +69,11 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151764498
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -101,9 +101,13 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151764317
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151725539
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -75,9 +77,14 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151479595
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -80,6 +80,22 @@ package object config {
.bytesConf(ByteUnit.MiB)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151473749
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala
---
@@ -75,6 +75,7 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151473518
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -364,8 +372,10 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151473122
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -75,9 +77,14 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151472844
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -103,7 +103,11 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151472648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151472401
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -80,6 +80,22 @@ package object config {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151352379
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -60,9 +62,15 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151340713
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -75,9 +77,14 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151333181
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -75,9 +77,14 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151037948
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/AggregateHashMap.java
---
@@ -40,7 +42,7 @@
*/
public class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150929464
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/AggregateHashMap.java
---
@@ -40,7 +42,7 @@
*/
public class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150889421
--- Diff:
core/src/test/scala/org/apache/spark/memory/UnifiedMemoryManagerSuite.scala ---
@@ -40,10 +42,12 @@ class UnifiedMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150889105
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +44,14 @@ class StaticMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150859426
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -60,9 +62,15 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150852190
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/AggregateHashMap.java
---
@@ -40,7 +42,7 @@
*/
public class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150848938
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -60,9 +62,15 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150847402
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/AggregateHashMap.java
---
@@ -40,7 +42,7 @@
*/
public class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150846694
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -351,11 +351,12 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150845551
--- Diff:
core/src/test/scala/org/apache/spark/memory/UnifiedMemoryManagerSuite.scala ---
@@ -40,10 +42,12 @@ class UnifiedMemoryManagerSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150845467
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +44,14 @@ class StaticMemoryManagerSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150840518
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150840015
--- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
---
@@ -195,7 +196,7 @@ private[spark] abstract class MemoryManager(
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r150839810
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -80,6 +80,11 @@ package object config {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r149418567
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r149415162
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r149382213
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r149382131
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111534878
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111534779
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -351,11 +351,12 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111530070
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -351,11 +351,12 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111528495
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -197,11 +200,17 @@ public void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111522359
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -197,11 +200,17 @@ public
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111522248
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111421994
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -197,11 +200,17 @@ public void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111421428
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -48,7 +48,10 @@ class StaticMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111420510
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -351,11 +351,12 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111420155
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -197,11 +200,17 @@ public
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111419534
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -351,11 +351,12 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111411947
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -90,6 +91,8 @@
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111397563
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -90,6 +91,8 @@
*/
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111372491
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -90,6 +91,8 @@
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111366006
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -90,6 +91,8 @@
*/
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r31172
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -90,6 +91,8 @@
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r01490
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -48,7 +48,10 @@ class StaticMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r00556
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -48,7 +48,10 @@ class StaticMemoryManagerSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111098912
--- Diff:
core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala ---
@@ -210,7 +210,7 @@ object UnifiedMemoryManager {
private def
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111095838
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -351,11 +351,12 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111094256
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -90,6 +91,8 @@
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r111062746
--- Diff:
core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala ---
@@ -210,7 +210,7 @@ object UnifiedMemoryManager {
private def
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r110923167
--- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java ---
@@ -41,7 +41,7 @@ protected MemoryConsumer(TaskMemoryManager
taskMemoryManager,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r110891992
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -351,11 +351,12 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r110889293
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -48,7 +48,10 @@ class StaticMemoryManagerSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r110838855
--- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java ---
@@ -41,7 +41,7 @@ protected MemoryConsumer(TaskMemoryManager
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r110801228
--- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java ---
@@ -41,7 +41,7 @@ protected MemoryConsumer(TaskMemoryManager
taskMemoryManager,
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r110714213
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -67,6 +67,9 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r110576977
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -67,6 +67,9 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r110576873
--- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java ---
@@ -41,7 +41,7 @@ protected MemoryConsumer(TaskMemoryManager
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r108994791
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -430,12 +430,15 @@ public int numValidRows() {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r108989432
--- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java ---
@@ -41,7 +41,7 @@ protected MemoryConsumer(TaskMemoryManager
taskMemoryManager,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r108947566
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -430,12 +430,15 @@ public int numValidRows() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r108946488
--- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java ---
@@ -41,7 +41,7 @@ protected MemoryConsumer(TaskMemoryManager
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/17436
[SPARK-20101][SQL] Use OffHeapColumnVector when
"spark.memory.offHeap.enabled" is set to "true"
## What changes were proposed in this pull request?
This PR enables to use
74 matches
Mail list logo
