Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19083
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142582571
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -380,23 +380,26 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142582458
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -380,23 +380,26 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142577265
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -151,7 +151,7 @@ class WholeStageCodegenSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142577237
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -17,10 +17,10 @@
package
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142577111
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -333,33 +334,28 @@ class AggregateBenchmark
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142576983
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -333,33 +334,28 @@ class AggregateBenchmark
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142559152
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -151,7 +151,7 @@ class WholeStageCodegenSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142558620
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -380,23 +380,24 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142558540
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -380,23 +380,24 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142558314
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -380,23 +380,24 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142527524
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1020,10 +1006,14 @@ abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142503474
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -32,7 +32,7 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142503203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1020,10 +1006,14 @@ abstract class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142059729
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -432,25 +432,31 @@ class DataFrameAggregateSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142059351
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -432,25 +432,31 @@ class DataFrameAggregateSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058947
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1092,13 +1082,30 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058941
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -432,25 +432,31 @@ class DataFrameAggregateSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058817
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1092,13 +1082,30 @@ object
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058550
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1020,6 +1006,10 @@ abstract class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058540
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1092,13 +1082,30 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058489
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1020,6 +1006,10 @@ abstract class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058408
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1092,13 +1082,30 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1092,13 +1082,30 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142058236
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1092,13 +1082,30 @@ object
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142053683
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1092,13 +1082,30 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142053181
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1092,13 +1082,30 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142037322
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -301,10 +301,10 @@ class AggregateBenchmark
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142020549
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -30,8 +30,15 @@ SELECT a + 2, COUNT(b) FROM testData GROUP BY a + 1;
SELECT a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142020459
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala
---
@@ -228,29 +241,35 @@ class DataFrameTimeWindowingSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142020462
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2102,25 +2102,31 @@ class SQLQuerySuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142020453
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala
---
@@ -95,50 +96,62 @@ class DataFrameTimeWindowingSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142020457
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala
---
@@ -95,50 +96,62 @@ class DataFrameTimeWindowingSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142020451
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -416,25 +416,31 @@ class DataFrameAggregateSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142020435
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -30,8 +30,15 @@ SELECT a + 2, COUNT(b) FROM testData GROUP BY a + 1;
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142018768
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -585,10 +586,22 @@ object SQLConf {
.doc("The maximum
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142018586
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -585,10 +586,22 @@ object SQLConf {
.doc("The maximum
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142012782
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -585,10 +586,22 @@ object SQLConf {
.doc("The maximum
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142012633
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -585,10 +586,22 @@ object SQLConf {
.doc("The maximum
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r142000625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1074,13 +1078,30 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r141998362
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1074,13 +1078,30 @@ object CodeGenerator
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r137453624
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -98,19 +99,23 @@ class CodeGenerationSuite
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r137378351
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -98,19 +99,23 @@ class CodeGenerationSuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136266187
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136250152
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136240836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136240918
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1058,7 +1068,17 @@ object CodeGenerator
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136240660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1058,7 +1068,17 @@ object CodeGenerator
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136240500
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1079,7 +1099,7 @@ object CodeGenerator
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136239358
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1079,7 +1099,7 @@ object CodeGenerator
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136237952
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135997033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135996601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135992714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135990600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135985618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135988601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1091,6 +,7 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135989181
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -176,34 +176,46 @@ class WholeStageCodegenSuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135955285
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -30,8 +30,15 @@ SELECT a + 2, COUNT(b) FROM testData GROUP BY a + 1;
SELECT a
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/19083
[SPARK-21871][SQL] Check actual bytecode size when compiling generated code
## What changes were proposed in this pull request?
This pr added code to check actual bytecode size when compiling
60 matches
Mail list logo
