Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19160
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r140051678
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -248,6 +251,16 @@ private[spark] class BlockManager(
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139861892
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
---
@@ -117,6 +118,12 @@ public void
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139861341
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -115,6 +115,7 @@ private[spark] class Executor(
if (!isLocal) {
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139861303
--- Diff:
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleServiceSource.scala
---
@@ -19,19 +19,19 @@ package org.apache.spark.deploy
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139860969
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala
---
@@ -18,11 +18,14 @@
package
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139860924
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -248,6 +251,16 @@ private[spark] class BlockManager(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139815684
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleClient.java
---
@@ -52,4 +55,13 @@ public abstract void
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139815983
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
---
@@ -117,6 +118,12 @@ public void
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139800662
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -115,6 +115,7 @@ private[spark] class Executor(
if (!isLocal) {
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139796177
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala
---
@@ -18,11 +18,14 @@
package
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139795417
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -248,6 +251,16 @@ private[spark] class BlockManager(
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139799940
--- Diff:
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleServiceSource.scala
---
@@ -19,19 +19,19 @@ package org.apache.spark.deploy
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/19160
[SPARK-21934][CORE] Expose Shuffle Netty memory usage to MetricsSystem
## What changes were proposed in this pull request?
This is a followup work of SPARK-9104 to expose the Netty
14 matches
Mail list logo
