Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19281
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r140381057
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -96,6 +96,24 @@ object SortOrder {
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r140215077
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -787,4 +789,64 @@ class JoinSuite extends QueryTest with
SharedSQLContext {
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r140191382
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -102,13 +102,22 @@ case class SortMergeJoinExec(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r140189310
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -96,6 +96,24 @@ object SortOrder {
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r140188874
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -96,6 +96,24 @@ object SortOrder {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139875187
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -101,14 +101,15 @@ case class SortMergeJoinExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139875333
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -64,6 +67,42 @@ class JoinSuite extends QueryTest with SharedSQLContext {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139873950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -396,6 +396,26 @@ abstract class SparkPlan extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139873547
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -396,6 +396,26 @@ abstract class SparkPlan extends
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139850950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -101,14 +101,15 @@ case class SortMergeJoinExec(
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139850236
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -64,6 +67,42 @@ class JoinSuite extends QueryTest with SharedSQLContext {
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139850127
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -64,6 +67,42 @@ class JoinSuite extends QueryTest with SharedSQLContext {
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139849801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -396,6 +396,26 @@ abstract class SparkPlan extends
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139844429
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -396,6 +396,26 @@ abstract class SparkPlan extends
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19281#discussion_r139820801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -396,6 +396,26 @@ abstract class SparkPlan extends
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/19281
[SPARK-21998][SQL] SortMergeJoinExec did not calculate its outputOrdering
correctly during physical planning
## What changes were proposed in this pull request?
Right now the
17 matches
Mail list logo
