Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19287
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141953125
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -744,6 +744,112 @@ class TaskSetManagerSuite extends SparkFunSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141953243
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -744,6 +744,112 @@ class TaskSetManagerSuite extends SparkFunSuite
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141784872
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,13 @@ class TaskInfo(
*/
var finishTime: Long =
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141784812
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -744,6 +744,100 @@ class TaskSetManagerSuite extends
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141784747
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -744,6 +744,100 @@ class TaskSetManagerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141677782
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,13 @@ class TaskInfo(
*/
var finishTime: Long = 0
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141676882
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -74,6 +81,10 @@ class TaskInfo(
gettingResultTime = time
}
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141676828
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,13 @@ class TaskInfo(
*/
var finishTime: Long = 0
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141674771
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -744,6 +744,100 @@ class TaskSetManagerSuite extends SparkFunSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141672604
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -744,6 +744,100 @@ class TaskSetManagerSuite extends SparkFunSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141643992
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -724,6 +724,7 @@ private[spark] class TaskSetManager(
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141668660
--- Diff: core/src/test/scala/org/apache/spark/scheduler/FakeTask.scala ---
@@ -58,4 +57,18 @@ object FakeTask {
}
new TaskSet(tasks,
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141674264
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -744,6 +744,100 @@ class TaskSetManagerSuite extends SparkFunSuite
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141513379
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -74,6 +81,10 @@ class TaskInfo(
gettingResultTime = time
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141510861
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -74,6 +81,10 @@ class TaskInfo(
gettingResultTime = time
}
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140996395
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -74,6 +81,10 @@ class TaskInfo(
gettingResultTime = time
}
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140995846
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,13 @@ class TaskInfo(
*/
var finishTime: Long = 0
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140788231
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -93,6 +104,8 @@ class TaskInfo(
def running: Boolean =
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140776344
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -93,6 +104,8 @@ class TaskInfo(
def running: Boolean =
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140776152
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,13 @@ class TaskInfo(
*/
var finishTime: Long = 0
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140143293
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,12 @@ class TaskInfo(
*/
var finishTime: Long =
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140047573
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,12 @@ class TaskInfo(
*/
var finishTime: Long =
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/19287
[SPARK-22074][Core] Task killed by other attempt task should not be
resubmitted
## What changes were proposed in this pull request?
As the detail scenario described in
24 matches
Mail list logo