Github user bdwyer2 closed the pull request at:
https://github.com/apache/spark/pull/19342
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19342#discussion_r140958369
--- Diff: R/pkg/DESCRIPTION ---
@@ -59,3 +59,4 @@ Collate:
'window.R'
RoxygenNote: 5.0.1
VignetteBuilder: knitr
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19342#discussion_r140958315
--- Diff: R/pkg/DESCRIPTION ---
@@ -59,3 +59,4 @@ Collate:
'window.R'
RoxygenNote: 5.0.1
VignetteBuilder: knitr
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19342#discussion_r140957541
--- Diff: R/pkg/DESCRIPTION ---
@@ -59,3 +59,4 @@ Collate:
'window.R'
RoxygenNote: 5.0.1
VignetteBuilder: knitr
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19342#discussion_r140957870
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3250,6 +3250,7 @@ setMethod("attach",
function(what, pos = 2, name = deparse(substitute(what)),
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19342#discussion_r140920250
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3250,6 +3250,7 @@ setMethod("attach",
function(what, pos = 2, name = deparse(substitute(what)),
GitHub user bdwyer2 opened a pull request:
https://github.com/apache/spark/pull/19342
[MINOR][SparkR] minor fixes for CRAN compliance
## What changes were proposed in this pull request?
Added `SystemRequirements` field to the `Description` file and added an
`on.exit()`
