Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19344#discussion_r141667464
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -67,10 +67,8 @@ object TPCDSQueryBenchmark
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19344#discussion_r141522496
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -66,25 +68,23 @@ object TPCDSQueryBenchmark
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19344#discussion_r141520921
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -66,25 +68,23 @@ object TPCDSQueryBenchmark
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19344#discussion_r141520163
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -66,25 +68,23 @@ object TPCDSQueryBenchmark
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/19344
[SPARK-22122][SQL] Respect WITH clauses to count input rows in
TPCDSQueryBenchmark
## What changes were proposed in this pull request?
Since the current code ignores WITH clauses to check input
