[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19467 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144403807 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -50,7 +50,8 @@ case class EnsureRequirements(conf:

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144434463 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StatefulOperatorTest.scala --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144434390 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StatefulOperatorTest.scala --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144433715 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala --- @@ -214,7 +214,7 @@ class StateStoreRDDSuite

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144402006 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -243,8 +246,9 @@ case class

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144408406 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EnsureStatefulOpPartitioningSuite.scala --- @@ -53,7 +53,7 @@ class

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144406045 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -43,10 +43,11 @@ case class

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144406113 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -239,7 +240,7 @@ case class StateStoreRestoreExec(

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-12 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144335223 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -590,10 +590,33 @@ case class

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-11 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144154295 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -590,10 +590,33 @@ case class

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-11 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144152923 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -131,17 +132,17 @@ class IncrementalExecution(

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-11 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144152859 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -131,17 +132,17 @@ class IncrementalExecution(

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-11 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19467#discussion_r144152254 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -590,10 +590,33 @@ case class

[GitHub] spark pull request #19467: [SPARK-22238] Fix plan resolution bug caused by E...

2017-10-10 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/19467 [SPARK-22238] Fix plan resolution bug caused by EnsureStatefulOpPartitioning ## What changes were proposed in this pull request? In EnsureStatefulOpPartitioning, we check that the inputRDD