[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19589 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19589#discussion_r147545176 --- Diff: R/pkg/tests/run-all.R --- @@ -38,6 +38,10 @@ sparkRFilesBefore <- list.files(path = sparkRDir, all.files = TRUE) sparkRTestMaster <-

[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19589#discussion_r147545114 --- Diff: R/pkg/inst/tests/testthat/test_basic.R --- @@ -18,7 +18,11 @@ context("basic tests for CRAN") test_that("create DataFrame from

[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19589#discussion_r147545247 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -36,6 +36,12 @@ opts_hooks$set(eval = function(options) { } options })

[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19589#discussion_r147545213 --- Diff: R/pkg/tests/run-all.R --- @@ -38,6 +38,10 @@ sparkRFilesBefore <- list.files(path = sparkRDir, all.files = TRUE) sparkRTestMaster <-

[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19589#discussion_r147545189 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -57,7 +63,7 @@ We use default settings in which it runs in local mode. It auto downloads Spark

[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19589#discussion_r147545171 --- Diff: R/pkg/tests/run-all.R --- @@ -38,6 +38,10 @@ sparkRFilesBefore <- list.files(path = sparkRDir, all.files = TRUE) sparkRTestMaster <-

[GitHub] spark pull request #19589: [SPARKR][SPARK-22344] Set java.io.tmpdir for Spar...

2017-10-27 Thread shivaram
GitHub user shivaram opened a pull request: https://github.com/apache/spark/pull/19589 [SPARKR][SPARK-22344] Set java.io.tmpdir for SparkR tests This PR sets the java.io.tmpdir for CRAN checks and also disables the hsperfdata for the JVM when running CRAN checks. Together this