Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19878
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154845901
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -730,23 +776,29 @@ case class HiveHash(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154819410
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -730,23 +776,29 @@ case class HiveHash(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154819030
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -610,25 +637,44 @@ case class HiveHash(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154818350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -610,25 +637,44 @@ case class HiveHash(children:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154805001
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -270,17 +270,36 @@ abstract class HashExpression[E]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154691937
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -389,13 +408,21 @@ abstract class HashExpression[E]
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154687417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -389,13 +408,21 @@ abstract class HashExpression[E]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154683889
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -730,23 +776,29 @@ case class HiveHash(children:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154683716
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -270,17 +270,36 @@ abstract class HashExpression[E]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19878#discussion_r154682872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -270,17 +270,36 @@ abstract class HashExpression[E]
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19878
[SPARK-22682][SQL] HashExpression does not need to create global variables
## What changes were proposed in this pull request?
It turns out that `HashExpression` can pass around some
12 matches
Mail list logo
