[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2018-08-26 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r212850054 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20020 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158882294 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1970,6 +1970,19 @@ class SQLQuerySuite extends

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158416541 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -479,14 +468,15 @@ case class DataSource(

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158344919 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala --- @@ -148,7 +148,8 @@ object HiveAnalysis extends Rule[LogicalPlan] {

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158344489 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -479,14 +468,15 @@ case class DataSource(

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158341954 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158341832 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -27,7 +27,7 @@ import

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158333591 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,44 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158329686 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,44 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158290698 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala --- @@ -118,13 +118,14 @@ class FileStreamSink(

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158290491 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -57,4 +59,6 @@ trait DataWritingCommand extends

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158288419 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,51 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158219553 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,51 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158203446 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158200471 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158197728 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158198595 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158198250 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,51 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158198088 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,51 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158199084 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158025766 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,18 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158019546 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,51 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-20 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158018917 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -57,4 +45,8 @@ trait DataWritingCommand extends

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-19 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/20020 [SPARK-22834][SQL] Make insertion commands have real children to fix UI issues ## What changes were proposed in this pull request? With #19474, children of insertion commands are