Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239994064
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239993480
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239992942
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -310,11 +439,23 @@ object StringIndexerModel extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239992845
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -310,11 +439,23 @@ object StringIndexerModel extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239992579
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239992360
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,26 +81,53 @@ private[feature] trait StringIndexerBase extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239992378
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239991238
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239889212
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -177,32 +245,47 @@ object StringIndexer extends
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239887472
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239889869
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -310,11 +439,23 @@ object StringIndexerModel extends
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239885097
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,26 +81,53 @@ private[feature] trait StringIndexerBase extends
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239888373
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239887259
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239888591
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r239885459
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,60 @@ class StringIndexer @Since("1.4.0") (
GitHub user viirya reopened a pull request:
https://github.com/apache/spark/pull/20146
[SPARK-11215][ML] Add multiple columns support to StringIndexer
## What changes were proposed in this pull request?
This takes over #19621 to add multi-column support to StringIndexer.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/20146
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183619017
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +159,57 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183408802
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +161,53 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183404967
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +161,53 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183393215
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +161,53 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183344264
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183341186
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183339386
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183336177
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183334835
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,26 +80,56 @@ private[feature] trait StringIndexerBase extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r18752
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,26 +80,56 @@ private[feature] trait StringIndexerBase extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183257701
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183255152
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +161,53 @@ class StringIndexer @Since("1.4.0") (
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183253488
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,26 +80,56 @@ private[feature] trait StringIndexerBase extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r18325
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183253932
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,26 +80,56 @@ private[feature] trait StringIndexerBase extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183257676
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183254078
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +161,53 @@ class StringIndexer @Since("1.4.0") (
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183258353
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183257799
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,33 +295,32 @@ class StringIndexerModel (
@Since("1.4.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r183253904
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,26 +80,56 @@ private[feature] trait StringIndexerBase extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r163528221
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -331,4 +357,51 @@ class StringIndexerSuite
val
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r163528239
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -33,12 +33,38 @@ class StringIndexerSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r162777500
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +249,16 @@ object ParamValidators {
def
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r162715788
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +249,16 @@ object ParamValidators {
def
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r161039325
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -33,12 +33,38 @@ class StringIndexerSuite
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r161040131
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +249,16 @@ object ParamValidators {
def
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r161040537
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -331,4 +357,51 @@ class StringIndexerSuite
val
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r160066219
--- Diff: R/pkg/tests/fulltests/test_mllib_regression.R ---
@@ -126,15 +134,15 @@ test_that("spark.glm summary", {
out <-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r160066433
--- Diff: R/pkg/tests/fulltests/test_mllib_regression.R ---
@@ -174,17 +182,17 @@ test_that("spark.glm summary", {
expect_equal(stats$aic, rStats$aic)
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r160049837
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -348,12 +348,12 @@ test_that("spark.mlp", {
# Test random seed
#
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r160048655
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -348,12 +348,12 @@ test_that("spark.mlp", {
# Test random seed
#
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r160039165
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -348,12 +348,12 @@ test_that("spark.mlp", {
# Test random seed
#
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r159584417
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -348,12 +348,12 @@ test_that("spark.mlp", {
# Test random seed
#
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r159580805
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -313,7 +313,7 @@ test_that("spark.mlp", {
# Test predict method
--- End diff --
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r159579587
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -313,7 +313,7 @@ test_that("spark.mlp", {
# Test predict method
mlpTestDF <-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r159578004
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -348,12 +348,12 @@ test_that("spark.mlp", {
# Test random seed
#
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r159577911
--- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
@@ -313,7 +313,7 @@ test_that("spark.mlp", {
# Test predict method
mlpTestDF <-
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/20146
[SPARK-11215][ML] Add multiple columns support to StringIndexer
## What changes were proposed in this pull request?
This takes over #19621 to add multi-column support to StringIndexer.
56 matches
Mail list logo
