Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20369
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r164036851
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/writer/StreamWriter.java
---
@@ -37,8 +41,28 @@
*/
void
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r164036304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1110,6 +1110,13 @@ object SQLConf {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r164025211
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/writer/StreamWriter.java
---
@@ -37,8 +41,28 @@
*/
void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r164024953
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1110,6 +1110,13 @@ object SQLConf {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r164011714
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/sources/StreamingDataSourceV2Suite.scala
---
@@ -184,6 +184,24 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r164008791
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/writer/StreamWriter.java
---
@@ -37,8 +41,28 @@
*/
void
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r164007657
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1110,6 +1110,13 @@ object SQLConf {
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163930702
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/StreamWriteSupport.java
---
@@ -48,7 +48,7 @@
* @param options
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163751348
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/StreamWriteSupport.java
---
@@ -48,7 +48,7 @@
* @param options the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163751286
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -281,11 +281,9 @@ final class DataStreamWriter[T]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163751198
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/MicroBatchWriteSupport.java
---
@@ -1,60 +0,0 @@
-/*
- * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163751107
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -62,7 +62,7 @@ case class
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163628099
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/MicroBatchWriteSupport.java
---
@@ -1,60 +0,0 @@
-/*
- * Licensed
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163626800
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -281,11 +281,9 @@ final class DataStreamWriter[T]
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163620226
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -62,7 +62,7 @@ case class
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163619964
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/MicroBatchWriteSupport.java
---
@@ -1,60 +0,0 @@
-/*
- * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163533890
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -281,11 +281,9 @@ final class DataStreamWriter[T]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163532503
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/MicroBatchWriteSupport.java
---
@@ -1,60 +0,0 @@
-/*
- * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163531998
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -62,7 +62,7 @@ case class
GitHub user jose-torres opened a pull request:
https://github.com/apache/spark/pull/20369
[SPARK-23196] Unify continuous and microbatch V2 sinks
## What changes were proposed in this pull request?
Replace streaming V2 sinks with a unified StreamWriteSupport interface,
with
21 matches
Mail list logo
