Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20419
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r167958486
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1226,14 +1226,21 @@ class CodegenContext
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r167947791
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1226,14 +1226,21 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r167853559
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1226,14 +1226,21 @@ class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r167775177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1226,14 +1226,21 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r164951129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1227,12 +1227,13 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r164509380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -542,6 +542,7 @@ case class WholeStageCodegenExec(child:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r164321458
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -542,6 +542,7 @@ case class
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/20419
[SPARK-23032][SQL][FOLLOW-UP]Add codegenStageId in comment
## What changes were proposed in this pull request?
This PR always adds `codegenStageId` in comment of the generated class.
