Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20637
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213977445
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213884870
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213689187
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213556478
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213013507
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212960763
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212926645
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212882312
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212832680
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212832157
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212817682
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212805339
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212799852
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212683385
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212668425
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212649063
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212625801
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212621229
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212589702
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212584773
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212569851
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -70,7 +76,7 @@ object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212570823
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211812298
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -110,7 +116,7 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211693601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +45,30 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211468226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +45,30 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211370785
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211365612
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +45,30 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211132711
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211131717
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +45,30 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211132393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +45,30 @@ object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209822349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +43,29 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209692496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +43,29 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209416053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +43,29 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209180525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +43,29 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209178573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -170,6 +174,23 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209161074
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -170,6 +174,23 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r209160237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +43,29 @@ object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r208698654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -219,15 +235,17 @@ object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r208696353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -70,7 +72,8 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r208677733
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -142,7 +143,7 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r208677695
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -308,10 +319,10 @@ object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r206841463
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -142,7 +143,7 @@ object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r206702526
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -308,10 +319,10 @@ object
44 matches
Mail list logo
