Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20705
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r174637563
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -526,7 +526,7 @@ object SQLConf {
val
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r174019305
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -526,7 +526,7 @@ object SQLConf {
val
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r173358166
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -852,52 +846,52 @@ class
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r173331220
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -591,7 +591,7 @@ class MetastoreDataSourcesSuite
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r173332327
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -852,52 +846,52 @@ class MetastoreDataSourcesSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r173281238
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2476,7 +2477,7 @@ class SQLQuerySuite extends QueryTest with
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r173275865
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2476,7 +2477,7 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r172024213
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2150,7 +2150,8 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r172024043
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2150,7 +2150,8 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r172023909
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -147,6 +147,7 @@ def load(self, path=None, format=None, schema=None,
**options):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r172022980
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2150,7 +2150,8 @@ class SQLQuerySuite extends QueryTest with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r172022384
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -147,6 +147,7 @@ def load(self, path=None, format=None, schema=None,
**options):
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r172007674
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala
---
@@ -57,6 +57,16 @@
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r172007654
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -147,6 +147,7 @@ def load(self, path=None, format=None, schema=None,
**options):
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r171729865
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -147,8 +147,8 @@ def load(self, path=None, format=None, schema=None,
**options):
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r171668693
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -516,24 +516,19 @@ class SQLQuerySuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r171668051
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala
---
@@ -739,15 +739,15 @@
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r171657406
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -526,7 +526,7 @@ object SQLConf {
val
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20705
[SPARK-23553][TESTS] Tests should not assume the default value of
`spark.sql.sources.default`
## What changes were proposed in this pull request?
Currently, some tests have an
20 matches
Mail list logo
