[GitHub] spark pull request #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't c...

2018-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20893 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't c...

2018-03-27 Thread sahilTakiar
Github user sahilTakiar commented on a diff in the pull request: https://github.com/apache/spark/pull/20893#discussion_r177577783 --- Diff: core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala --- @@ -114,10 +114,10 @@ private[spark] abstract class LauncherBackend {

[GitHub] spark pull request #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't c...

2018-03-27 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20893#discussion_r177366836 --- Diff: core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala --- @@ -114,10 +114,10 @@ private[spark] abstract class LauncherBackend {

[GitHub] spark pull request #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't c...

2018-03-27 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20893#discussion_r177362825 --- Diff: core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala --- @@ -114,10 +114,10 @@ private[spark] abstract class LauncherBackend {

[GitHub] spark pull request #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't c...

2018-03-26 Thread sahilTakiar
Github user sahilTakiar commented on a diff in the pull request: https://github.com/apache/spark/pull/20893#discussion_r177208050 --- Diff: core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala --- @@ -114,10 +114,10 @@ private[spark] abstract class LauncherBackend {

[GitHub] spark pull request #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't c...

2018-03-25 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20893#discussion_r176978788 --- Diff: core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala --- @@ -114,10 +114,10 @@ private[spark] abstract class LauncherBackend {

[GitHub] spark pull request #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't c...

2018-03-23 Thread sahilTakiar
GitHub user sahilTakiar opened a pull request: https://github.com/apache/spark/pull/20893 [SPARK-23785][LAUNCHER] LauncherBackend doesn't check state of connection before setting state ## What changes were proposed in this pull request? Changed `LauncherBackend` `set`