[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21169 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r185528731 --- Diff: sql/core/src/test/resources/sql-tests/results/datetime.sql.out --- @@ -82,9 +82,138 @@ struct 1 2 2 3 +

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r185057781 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1208,6 +1208,13 @@ object SQLConf { .stringConf

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r185067161 --- Diff: docs/sql-programming-guide.md --- @@ -1805,12 +1805,13 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184852914 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -296,10 +296,28 @@ object DateTimeUtils {

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184731765 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1208,6 +1208,13 @@ object SQLConf { .stringConf

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184687634 --- Diff: sql/core/src/test/resources/sql-tests/results/datetime.sql.out --- @@ -82,9 +82,138 @@ struct 1 2 2 3 +

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184685378 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1208,6 +1208,13 @@ object SQLConf { .stringConf

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184608524 --- Diff: docs/sql-programming-guide.md --- @@ -1805,12 +1805,13 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184597402 --- Diff: docs/sql-programming-guide.md --- @@ -1805,12 +1805,13 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184596334 --- Diff: docs/sql-programming-guide.md --- @@ -1805,12 +1805,13 @@ working with timestamps in `pandas_udf`s to get the best performance, see -

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184590539 --- Diff: docs/sql-programming-guide.md --- @@ -1805,12 +1805,13 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184589060 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -782,6 +782,22 @@ object TypeCoercion {

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184569738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -782,6 +782,22 @@ object TypeCoercion {

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184565093 --- Diff: sql/core/src/test/resources/sql-tests/inputs/datetime.sql --- @@ -27,3 +27,8 @@ select current_date = current_date(), current_timestamp =

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21169#discussion_r184561518 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -296,10 +296,27 @@ object DateTimeUtils {

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/21169 [SPARK-23715][SQL] the input of to/from_utc_timestamp can not have timezone ## What changes were proposed in this pull request? `from_utc_timestamp` assumes its input is in UTC timezone