[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-08 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186635312 --- Diff: R/pkg/R/functions.R --- @@ -1253,19 +1256,6 @@ setMethod("quarter", column(jc) }) -#' @details -#'

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186634471 --- Diff: R/pkg/R/functions.R --- @@ -2043,34 +2033,6 @@ setMethod("countDistinct", column(jc) }) -#' @details

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186633965 --- Diff: R/pkg/R/functions.R --- @@ -1253,19 +1256,6 @@ setMethod("quarter", column(jc) }) -#' @details

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-08 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186631550 --- Diff: R/pkg/R/functions.R --- @@ -2043,34 +2033,6 @@ setMethod("countDistinct", column(jc) }) -#' @details

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-08 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186630904 --- Diff: R/pkg/R/functions.R --- @@ -1253,19 +1256,6 @@ setMethod("quarter", column(jc) }) -#' @details -#'

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186624915 --- Diff: R/pkg/R/functions.R --- @@ -2043,34 +2033,6 @@ setMethod("countDistinct", column(jc) }) -#' @details

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186624766 --- Diff: R/pkg/R/functions.R --- @@ -1253,19 +1256,6 @@ setMethod("quarter", column(jc) }) -#' @details

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186624379 --- Diff: R/pkg/R/functions.R --- @@ -209,6 +209,7 @@ NULL #' head(select(tmp, array_max(tmp$v1), array_min(tmp$v1))) #' head(select(tmp,

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186612820 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1739,6 +1748,13 @@ test_that("string operators", { collect(select(df5,

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186612845 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1739,6 +1748,13 @@ test_that("string operators", { collect(select(df5,

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186610290 --- Diff: R/pkg/R/functions.R --- @@ -218,6 +219,8 @@ NULL #' head(select(tmp3, map_keys(tmp3$v3))) #' head(select(tmp3, map_values(tmp3$v3)))

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186604950 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1748,6 +1748,14 @@ test_that("string operators", { collect(select(df5, repeat_string(df5$a,

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-07 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186604721 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1502,12 +1502,21 @@ test_that("column functions", { result <- collect(select(df,

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186368498 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1502,12 +1502,21 @@ test_that("column functions", { result <- collect(select(df,

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21255#discussion_r186369103 --- Diff: R/pkg/R/functions.R --- @@ -209,6 +209,7 @@ NULL #' head(select(tmp, array_max(tmp$v1), array_min(tmp$v1))) #' head(select(tmp,

[GitHub] spark pull request #21255: [SPARK-24186][SparR][SQL]change reverse and conca...

2018-05-07 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/21255 [SPARK-24186][SparR][SQL]change reverse and concat to collection functions in R ## What changes were proposed in this pull request? reverse and concat are already in functions.R as