Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21454
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191944805
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,22 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191944797
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,22 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191945182
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -339,6 +340,38 @@ class SparkConfSuite extends SparkFunSuite with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191883353
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,20 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191899959
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -339,6 +341,38 @@ class SparkConfSuite extends SparkFunSuite with
Github user PenguinToast commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191849201
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -339,6 +341,38 @@ class SparkConfSuite extends SparkFunSuite with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191626037
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -25,14 +25,16 @@ import scala.language.postfixOps
import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191625768
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -339,6 +341,38 @@ class SparkConfSuite extends SparkFunSuite with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191625705
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,20 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191625505
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -265,108 +265,121 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191582665
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -394,23 +407,35 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191584812
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,20 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191582499
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -394,23 +407,35 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191582611
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -394,23 +407,35 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
GitHub user PenguinToast opened a pull request:
https://github.com/apache/spark/pull/21454
[SPARK-24337][Core] Improve error messages for Spark conf values
## What changes were proposed in this pull request?
Improve the exception messages when retrieving Spark conf values
16 matches
Mail list logo
