Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21462
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r199307562
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -46,8 +46,6 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r199228479
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -46,8 +46,6 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r199071328
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -46,8 +46,6 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r198795717
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -46,8 +46,6 @@
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r197909183
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r197909535
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -46,8 +46,6 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r196395479
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r195900804
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r195900749
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r195639021
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r193985639
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r193985575
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r193982361
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -46,8 +46,6 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r193981514
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -46,12 +46,6 @@ shift 1
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r192925875
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -46,12 +46,6 @@ shift 1
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r192023771
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191948799
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191940083
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191936265
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191930265
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191775677
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -46,12 +46,6 @@ shift 1
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/21462
[SPARK-24428][K8S] Fix unused code
## What changes were proposed in this pull request?
Remove code that is misleading and is a leftover from previous
implementation.
## How was
23 matches
Mail list logo
