[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-09-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r220413827 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -700,6 +722,82 @@ class RandomForestSuite extends

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-09-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r220413857 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala --- @@ -159,6 +169,31 @@ class

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-09-18 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r218657097 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -66,6 +69,9 @@ class DecisionTreeClassifier

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-09-18 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r218657039 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala --- @@ -65,6 +68,9 @@ class DecisionTreeRegressor

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-09-18 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r218657065 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -97,28 +103,48 @@ class DecisionTreeClassifier

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-08-14 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r209839725 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -66,6 +69,9 @@ class DecisionTreeClassifier

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-08-14 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r209839825 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala --- @@ -65,6 +68,9 @@ class DecisionTreeRegressor

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-08-14 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r209839752 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -97,28 +103,48 @@ class DecisionTreeClassifier

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-08-14 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r209840163 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -700,6 +722,82 @@ class RandomForestSuite extends

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-08-14 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r209840017 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala --- @@ -159,6 +169,31 @@ class

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-06-24 Thread imatiach-msft
GitHub user imatiach-msft opened a pull request: https://github.com/apache/spark/pull/21632 [SPARK-19591][ML][MLlib] Add sample weights to decision trees This is updated PR https://github.com/apache/spark/pull/16722 What changes were proposed in this pull request?