Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22976
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r233787377
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -133,30 +126,26 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r233771918
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,62 +68,55 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r233771269
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,62 +68,55 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r233764857
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -133,30 +126,26 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r233765313
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,62 +68,55 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r232552336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,62 +68,55 @@ object
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r232474090
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -133,7 +126,6 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r232443266
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,57 +68,50 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r232443230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -133,7 +126,6 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r232443205
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -154,7 +146,6 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r231886019
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,57 +68,51 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r231886071
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,57 +68,51 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r231885902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,57 +68,51 @@ object
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/22976
[SPARK-25974][SQL]Optimizes Generates bytecode for ordering based on the
given order
## What changes were proposed in this pull request?
Currently, when generates the code for ordering
15 matches
Mail list logo