[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23166 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237886286 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -708,16 +709,36 @@ private[spark] class PythonBroadcast(@transient var

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-30 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237875851 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -708,16 +709,36 @@ private[spark] class PythonBroadcast(@transient var

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-29 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237738802 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -708,16 +709,36 @@ private[spark] class PythonBroadcast(@transient var

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-29 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237652232 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -708,16 +709,36 @@ private[spark] class PythonBroadcast(@transient var

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-29 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237535187 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -708,16 +709,36 @@ private[spark] class PythonBroadcast(@transient var

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-28 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237250388 --- Diff: python/pyspark/broadcast.py --- @@ -134,7 +137,15 @@ def value(self): """ Return the broadcasted value """

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-28 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237248890 --- Diff: python/pyspark/broadcast.py --- @@ -134,7 +137,15 @@ def value(self): """ Return the broadcasted value """

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-28 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237231750 --- Diff: python/pyspark/broadcast.py --- @@ -118,8 +121,16 @@ def dump(self, value, f): f.close() def load_from_path(self,

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-28 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237228157 --- Diff: python/pyspark/broadcast.py --- @@ -118,8 +121,16 @@ def dump(self, value, f): f.close() def load_from_path(self,

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-28 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/23166#discussion_r237212353 --- Diff: python/pyspark/tests/test_broadcast.py --- @@ -67,6 +67,20 @@ def test_broadcast_with_encryption(self): def

[GitHub] spark pull request #23166: [SPARK-26201] Fix python broadcast with encryptio...

2018-11-28 Thread redsanket
GitHub user redsanket opened a pull request: https://github.com/apache/spark/pull/23166 [SPARK-26201] Fix python broadcast with encryption ## What changes were proposed in this pull request? Python with rpc and disk encryption enabled along with a python broadcast variable and