Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23173
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238091149
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238077135
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238073218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238070641
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238068538
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238064338
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238059569
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1987,6 +1987,21 @@ class CSVSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238059480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238058669
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r238058594
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237883918
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237884151
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -171,15 +171,21 @@ private[csv] class
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237716913
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/OutputWriter.scala
---
@@ -57,6 +57,9 @@ abstract class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237711250
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/OutputWriter.scala
---
@@ -57,6 +57,9 @@ abstract class
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237687091
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1987,6 +1987,18 @@ class CSVSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237679872
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1987,6 +1987,18 @@ class CSVSuite extends
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237663865
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1987,6 +1987,18 @@ class CSVSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237633755
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1987,6 +1987,18 @@ class CSVSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237635061
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1987,6 +1987,18 @@ class CSVSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237634432
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1987,6 +1987,18 @@ class CSVSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237633638
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1987,6 +1987,18 @@ class CSVSuite extends
Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237579324
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/OutputWriter.scala
---
@@ -57,6 +57,9 @@ abstract class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23173#discussion_r237561245
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/OutputWriter.scala
---
@@ -57,6 +57,9 @@ abstract class OutputWriterFactory
GitHub user koertkuipers opened a pull request:
https://github.com/apache/spark/pull/23173
[SPARK-26208][SQL] add headers to empty csv files when header=true
## What changes were proposed in this pull request?
Add headers to empty csv files when header=true, because
25 matches
Mail list logo