[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22666 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22902: [SPARK-25893][SQL] Show a directional error message for ...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22902 **[Test build #98312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98312/testReport)** for PR 22902 at commit

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22666 **[Test build #98313 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98313/testReport)** for PR 22666 at commit

[GitHub] spark issue #22902: [SPARK-25893][SQL] Show a directional error message for ...

2018-10-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22902 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22903: [SPARK-24196][SQL] Implement Spark's own GetSchem...

2018-10-31 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22903#discussion_r229649065 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkMetadataOperationSuite.scala --- @@ -0,0 +1,103 @@ +/*

[GitHub] spark issue #22903: [SPARK-24196][SQL] Implement Spark's own GetSchemasOpera...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22903 **[Test build #98311 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98311/testReport)** for PR 22903 at commit

[GitHub] spark issue #22903: [SPARK-24196][SQL] Implement Spark's own GetSchemasOpera...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22903 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98311/ Test PASSed. ---

[GitHub] spark issue #22902: [SPARK-25893][SQL] Show a directional error message for ...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22902 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22902: [SPARK-25893][SQL] Show a directional error message for ...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22903: [SPARK-24196][SQL] Implement Spark's own GetSchemasOpera...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22903 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22880: [SPARK-25407][SQL] Ensure we pass a compatible pr...

2018-10-31 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/22880#discussion_r229654276 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -202,11 +204,15 @@ private[parquet]

[GitHub] spark issue #22899: [SPARK-25573] Combine resolveExpression and resolve in t...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22899 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22899: [SPARK-25573] Combine resolveExpression and resolve in t...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22899 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22899: [SPARK-25573] Combine resolveExpression and resolve in t...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22899 **[Test build #98314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98314/testReport)** for PR 22899 at commit

[GitHub] spark issue #22906: [SPARK-25895][Core]Adding testcase to compare Lz4 and Zs...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22906 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22857 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22857: [SPARK-25860][SQL] Replace Literal(null, _) with FalseLi...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22857 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22723: [SPARK-25729][CORE]It is better to replace `minPa...

2018-10-31 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22723#discussion_r229720799 --- Diff: core/src/main/scala/org/apache/spark/rdd/WholeTextFileRDD.scala --- @@ -51,7 +51,7 @@ private[spark] class WholeTextFileRDD( case _ =>

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22666 **[Test build #98313 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98313/testReport)** for PR 22666 at commit

[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22861 **[Test build #98310 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98310/testReport)** for PR 22861 at commit

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22666 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22892 **[Test build #98319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98319/testReport)** for PR 22892 at commit

[GitHub] spark pull request #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type ...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22905#discussion_r229754853 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -306,7 +306,15 @@ case class FileSourceScanExec(

[GitHub] spark pull request #22908: [MONOR][SQL] Replace all TreeNode's node name in ...

2018-10-31 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22908#discussion_r229761443 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -932,12 +932,12 @@ case class HashAggregateExec(

[GitHub] spark issue #22908: [MONOR][SQL] Replace all TreeNode's node name in the sim...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22908 **[Test build #98322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98322/testReport)** for PR 22908 at commit

[GitHub] spark pull request #22906: [SPARK-25895][Core]Adding testcase to compare Lz4...

2018-10-31 Thread Udbhav30
GitHub user Udbhav30 opened a pull request: https://github.com/apache/spark/pull/22906 [SPARK-25895][Core]Adding testcase to compare Lz4 and Zstd compression ## What changes were proposed in this pull request? Added a UT to verify Zstd compression algorithm has better

[GitHub] spark issue #22894: [SPARK-25885][Core][Minor] HighlyCompressedMapStatus des...

2018-10-31 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22894 that sounds more reasonable and a better implementation, thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type which r...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22905 is there anything blocked by this? I agree this is a good feature, but it asks the data source to provide a new ability, which may become a problem when migrating file sources to data source v2.

[GitHub] spark pull request #22029: [SPARK-24395][SQL] IN operator should return NULL...

2018-10-31 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22029#discussion_r229706800 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1561,6 +1561,16 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #22723: [SPARK-25729][CORE]It is better to replace `minPa...

2018-10-31 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/22723#discussion_r229717747 --- Diff: core/src/main/scala/org/apache/spark/input/WholeTextFileInputFormat.scala --- @@ -48,11 +50,11 @@ private[spark] class

[GitHub] spark pull request #22723: [SPARK-25729][CORE]It is better to replace `minPa...

2018-10-31 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/22723#discussion_r229717581 --- Diff: core/src/main/scala/org/apache/spark/input/WholeTextFileInputFormat.scala --- @@ -48,11 +50,11 @@ private[spark] class

[GitHub] spark pull request #22880: [SPARK-25407][SQL] Ensure we pass a compatible pr...

2018-10-31 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/22880#discussion_r229732302 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -202,11 +204,15 @@

[GitHub] spark issue #22899: [SPARK-25573] Combine resolveExpression and resolve in t...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22899 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22907: [SPARK-25896][CORE][WIP] Accumulator should only be upda...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22907 **[Test build #98321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98321/testReport)** for PR 22907 at commit

[GitHub] spark pull request #22878: [SPARK-25789][SQL] Support for Dataset of Avro

2018-10-31 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22878#discussion_r229762665 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroEncoder.scala --- @@ -0,0 +1,534 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT,...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22892#discussion_r229672667 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveShowCreateTableSuite.scala --- @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type ...

2018-10-31 Thread mallman
GitHub user mallman opened a pull request: https://github.com/apache/spark/pull/22905 [SPARK-25894][SQL] Add a ColumnarFileFormat type which returns the column count for a given schema (link to Jira: https://issues.apache.org/jira/browse/SPARK-25894) ## What changes were

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22892 **[Test build #98309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98309/testReport)** for PR 22892 at commit

[GitHub] spark issue #22902: [SPARK-25893][SQL] Show a directional error message for ...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22902 **[Test build #98312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98312/testReport)** for PR 22902 at commit

[GitHub] spark issue #22902: [SPARK-25893][SQL] Show a directional error message for ...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22902 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98312/ Test PASSed. ---

[GitHub] spark issue #22902: [SPARK-25893][SQL] Show a directional error message for ...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22902 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22894: [SPARK-25885][Core][Minor] HighlyCompressedMapStatus des...

2018-10-31 Thread Koraseg
Github user Koraseg commented on the issue: https://github.com/apache/spark/pull/22894 Thanks for the remark above. I have checked scala.mutable.Map performance, it is essentially better. For some cases, speed up is up to 2 times I will update the benchmark and the PR soon. ---

[GitHub] spark pull request #22029: [SPARK-24395][SQL] IN operator should return NULL...

2018-10-31 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22029#discussion_r229706218 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -212,27 +212,27 @@ object

[GitHub] spark issue #22893: [SPARK-25868][MLlib] One part of Spark MLlib Kmean Logic...

2018-10-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22893 I don't think BLAS matters here as these are all vector-vector operations and f2jblas is used directly (i.e. stays in the JVM). Are all the vectors dense? I suppose I'm still surprised if

[GitHub] spark pull request #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type ...

2018-10-31 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/22905#discussion_r229729687 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -306,7 +306,15 @@ case class FileSourceScanExec(

[GitHub] spark pull request #22880: [SPARK-25407][SQL] Ensure we pass a compatible pr...

2018-10-31 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/22880#discussion_r229743035 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -202,11 +204,15 @@ private[parquet]

[GitHub] spark issue #22898: [SPARK-25746][SQL][followup] do not add unnecessary If e...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22898 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98315/ Test PASSed. ---

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-31 Thread patrickbrownsync
Github user patrickbrownsync commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r229762873 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -92,6 +94,16 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark pull request #22895: [SPARK-25886][SQL][Minor] Improve error message o...

2018-10-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22895 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22892 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22892 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98309/ Test PASSed. ---

[GitHub] spark pull request #22029: [SPARK-24395][SQL] IN operator should return NULL...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22029#discussion_r229701584 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -212,27 +212,27 @@ object

[GitHub] spark pull request #22857: [SPARK-25860][SQL] Replace Literal(null, _) with ...

2018-10-31 Thread aokolnychyi
Github user aokolnychyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22857#discussion_r229705741 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2585,4 +2585,45 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #22906: [SPARK-25895][Core]Adding testcase to compare Lz4...

2018-10-31 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22906#discussion_r229723135 --- Diff: core/src/test/scala/org/apache/spark/io/CompressionCodecSuite.scala --- @@ -128,6 +130,69 @@ class CompressionCodecSuite extends SparkFunSuite {

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22029 **[Test build #98318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98318/testReport)** for PR 22029 at commit

[GitHub] spark issue #22864: [SPARK-25861][Minor][WEBUI] Remove unused refreshInterva...

2018-10-31 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22864 I will fix the build error. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22892 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22880: [SPARK-25407][SQL] Ensure we pass a compatible pr...

2018-10-31 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/22880#discussion_r229739407 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -202,11 +204,15 @@ private[parquet]

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22892 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22880: [SPARK-25407][SQL] Ensure we pass a compatible pr...

2018-10-31 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/22880#discussion_r229738879 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -202,11 +204,15 @@ private[parquet]

[GitHub] spark issue #22898: [SPARK-25746][SQL][followup] do not add unnecessary If e...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22898 **[Test build #98315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98315/testReport)** for PR 22898 at commit

[GitHub] spark pull request #22908: [MONOR][SQL] Replace all TreeNode's node name in ...

2018-10-31 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/22908 [MONOR][SQL] Replace all TreeNode's node name in the simpleString as their nodeName ## What changes were proposed in this pull request? This pr replace all `TreeNode`'s node name in the

[GitHub] spark issue #22908: [MONOR][SQL] Replace all TreeNode's node name in the sim...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22908 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22908: [MONOR][SQL] Replace all TreeNode's node name in the sim...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22908 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22878: [SPARK-25789][SQL] Support for Dataset of Avro

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22878 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-31 Thread patrickbrownsync
Github user patrickbrownsync commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r229763610 --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala --- @@ -456,9 +458,63 @@ class KryoSerializerSuite extends

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-31 Thread patrickbrownsync
Github user patrickbrownsync commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r229763892 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -84,6 +85,7 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark issue #22878: [SPARK-25789][SQL] Support for Dataset of Avro

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22878 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20899: Bug fix in sendMessage() of pregel implementation in Pag...

2018-10-31 Thread WenqianZhao
Github user WenqianZhao commented on the issue: https://github.com/apache/spark/pull/20899 By the way, @ankurdave , hi, I'm very curious about why you use delta instead of just newPR as the message. Is that for better performance or just at chance? Could you please answer this

[GitHub] spark issue #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type which r...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22905 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type which r...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22905 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type which r...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22905 **[Test build #98316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98316/testReport)** for PR 22905 at commit

[GitHub] spark issue #22906: [SPARK-25895][Core]Adding testcase to compare Lz4 and Zs...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22906 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22906: [SPARK-25895][Core]Adding testcase to compare Lz4 and Zs...

2018-10-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22906 I don't think this tests something about the correctness of Spark though. I am not sure this is worth it. --- - To unsubscribe,

[GitHub] spark pull request #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT,...

2018-10-31 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22892#discussion_r229737749 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveShowCreateTableSuite.scala --- @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-10-31 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22237 @HyukjinKwon Thank you for following up work on the PR. @cloud-fan @viirya @maropu Thanks for your reviews. --- - To

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-10-31 Thread patrickbrownsync
Github user patrickbrownsync commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r229762474 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -92,6 +94,16 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22892 LGTM except some minor comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22905: [SPARK-25894][SQL] Add a ColumnarFileFormat type which r...

2018-10-31 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/22905 @gatorsmile @viirya @cloud-fan @dbtsai your thoughts? cc @dongjoon-hyun for ORC file format perspective. --- - To

[GitHub] spark pull request #22029: [SPARK-24395][SQL] IN operator should return NULL...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22029#discussion_r229708259 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -212,27 +212,27 @@ object

[GitHub] spark issue #22666: [SPARK-25672][SQL] schema_of_csv() - schema inference fr...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22666 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98313/ Test PASSed. ---

[GitHub] spark pull request #22907: [SPARK-25896][CORE][WIP] Accumulator should only ...

2018-10-31 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22907 [SPARK-25896][CORE][WIP] Accumulator should only be updated once for each successful task in shuffle map stage ## What changes were proposed in this pull request? This is a followup of

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-31 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22288 @dhruve is this ready to review again? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22898: [SPARK-25746][SQL][followup] do not add unnecessary If e...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22898 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22029: [SPARK-24395][SQL] IN operator should return NULL...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22029#discussion_r22978 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -212,27 +212,27 @@ object

[GitHub] spark issue #22901: [SPARK-25891][PYTHON] Upgrade to Py4J 0.10.8.1

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22901: [SPARK-25891][PYTHON] Upgrade to Py4J 0.10.8.1

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22901 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98305/ Test PASSed. ---

[GitHub] spark pull request #22029: [SPARK-24395][SQL] IN operator should return NULL...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22029#discussion_r229692081 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -202,7 +225,11 @@ case class InSubquery(values:

[GitHub] spark pull request #22029: [SPARK-24395][SQL] IN operator should return NULL...

2018-10-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22029#discussion_r229700708 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -212,27 +212,34 @@ object

[GitHub] spark issue #22901: [SPARK-25891][PYTHON] Upgrade to Py4J 0.10.8.1

2018-10-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22901 That sounds like a good idea. I wonder if it's safe to back-port to 2.4/2.3? should be if it's just a maintenance release. --- -

[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22861 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98310/ Test PASSed. ---

[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22861 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22864: [SPARK-25861][Minor][WEBUI] Remove unused refreshInterva...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22864 **[Test build #4399 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4399/testReport)** for PR 22864 at commit

[GitHub] spark issue #22899: [SPARK-25573] Combine resolveExpression and resolve in t...

2018-10-31 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22899 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22907: [SPARK-25896][CORE][WIP] Accumulator should only be upda...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22907 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22907: [SPARK-25896][CORE][WIP] Accumulator should only be upda...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22907 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-31 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22379 @HyukjinKwon Thank you for your work on the PR. @cloud-fan @felixcheung @dongjoon-hyun @gatorsmile Thanks for your reviews. ---

[GitHub] spark issue #22901: [SPARK-25891][PYTHON] Upgrade to Py4J 0.10.8.1

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22901 **[Test build #98305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98305/testReport)** for PR 22901 at commit

[GitHub] spark issue #22899: [SPARK-25573] Combine resolveExpression and resolve in t...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22899 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22899: [SPARK-25573] Combine resolveExpression and resolve in t...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22899 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98314/ Test FAILed. ---

  1   2   3   4   5   6   >