[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-05-04 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17300 Thanks both of you for review, I have addressed the comments and modified the test case. Please help calling jenkins for test, because I can't trigger that. Thanks again. --- If your project is

[GitHub] spark issue #17868: [CORE]Add new unit tests to ShuffleSuite

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17868 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17300: [SPARK-19956][Core]Optimize a location order of b...

2017-05-04 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17300#discussion_r114935050 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -555,12 +555,15 @@ private[spark] class BlockManager( /**

[GitHub] spark pull request #17868: [CORE]Add new unit tests to ShuffleSuite

2017-05-04 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/17868 [CORE]Add new unit tests to ShuffleSuite ## What changes were proposed in this pull request? This PR update to two: 1.adds the new unit tests. testing would be performed when

[GitHub] spark issue #17861: Remove excess quotes in Windows executable

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17861 @jarrettmeyer I think we should create a JIRA for this as it does look non-trivial fix although the line diff is single. Please refer http://spark.apache.org/contributing.html. --- If your

[GitHub] spark pull request #17861: Remove excess quotes in Windows executable

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17861#discussion_r114934079 --- Diff: bin/spark-class2.cmd --- @@ -64,7 +64,7 @@ if not "x%JAVA_HOME%"=="x" ( rem The launcher library prints the command to be executed in a

[GitHub] spark issue #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance among ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17844 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76471/ Test PASSed. ---

[GitHub] spark issue #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance among ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17844 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance among ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17844 **[Test build #76471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76471/testReport)** for PR 17844 at commit

[GitHub] spark issue #17864: [SPARK-20604][ML] Allow imputer to handle numeric types

2017-05-04 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/17864 @sethah Thanks for summarizing the previous discussions. What are you suggesting for this PR? I think it makes sense to log a warning when imputing integer types with mean. In addition,

[GitHub] spark issue #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17678 **[Test build #76480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76480/testReport)** for PR 17678 at commit

[GitHub] spark issue #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ...

2017-05-04 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/17678 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114932485 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76470/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76470/testReport)** for PR 17770 at commit

[GitHub] spark issue #17658: [SPARK-20355] Add per application spark version on the h...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17658 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17658: [SPARK-20355] Add per application spark version on the h...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17658 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76469/ Test PASSed. ---

[GitHub] spark issue #17658: [SPARK-20355] Add per application spark version on the h...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17658 **[Test build #76469 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76469/testReport)** for PR 17658 at commit

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114931344 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114931185 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark issue #17865: [SPARK-20456][Docs] Add examples for functions collectio...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17865 (Thank you @gatorsmile for triggering the test) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76478/testReport)** for PR 17770 at commit

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76478/ Test FAILed. ---

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114929441 --- Diff: python/pyspark/sql/functions.py --- @@ -153,7 +173,7 @@ def _(): # math functions that take two arguments as input

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114929075 --- Diff: python/pyspark/sql/functions.py --- @@ -131,9 +152,8 @@ def _(): 'var_pop': 'Aggregate function: returns the population variance of

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114930599 --- Diff: python/pyspark/sql/functions.py --- @@ -910,8 +941,8 @@ def weekofyear(col): """ Extract the week number of a given date as

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114929597 --- Diff: python/pyspark/sql/functions.py --- @@ -206,17 +226,20 @@ def _(): @since(1.3) def approxCountDistinct(col, rsd=None): """

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114929803 --- Diff: python/pyspark/sql/functions.py --- @@ -1120,12 +1159,12 @@ def from_utc_timestamp(timestamp, tz): @since(1.5) def

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114929993 --- Diff: python/pyspark/sql/functions.py --- @@ -67,9 +67,16 @@ def _(): _.__doc__ = 'Window function: ' + doc return _

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114929689 --- Diff: python/pyspark/sql/functions.py --- @@ -456,7 +479,7 @@ def monotonically_increasing_id(): def nanvl(col1, col2): """Returns

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114929646 --- Diff: python/pyspark/sql/functions.py --- @@ -397,7 +420,7 @@ def input_file_name(): @since(1.6) def isnan(col): -"""An

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17865#discussion_r114930366 --- Diff: python/pyspark/sql/functions.py --- @@ -793,8 +824,8 @@ def date_format(date, format): .. note:: Use when ever possible specialized

[GitHub] spark issue #17867: [SPARK-20606][ML] ML 2.2 QA: Remove deprecated methods f...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17867 **[Test build #76479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76479/testReport)** for PR 17867 at commit

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76476/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76476/testReport)** for PR 17770 at commit

[GitHub] spark pull request #17300: [SPARK-19956][Core]Optimize a location order of b...

2017-05-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17300#discussion_r114929963 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -555,12 +555,15 @@ private[spark] class BlockManager( /**

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114929845 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark pull request #17867: [SPARK-20606][ML] ML 2.2 QA: Remove deprecated me...

2017-05-04 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/17867 [SPARK-20606][ML] ML 2.2 QA: Remove deprecated methods for ML ## What changes were proposed in this pull request? Remove ML methods we deprecated in 2.1. ## How was this patch

[GitHub] spark pull request #17658: [SPARK-20355] Add per application spark version o...

2017-05-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17658#discussion_r114929683 --- Diff: core/src/test/resources/HistoryServerExpectations/completed_app_list_json_expectation.json --- @@ -22,6 +23,7 @@ "duration" : 101795,

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114929528 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

2017-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r114929436 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -36,7 +36,10 @@ import org.apache.spark.util.{Utils, VersionUtils}

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76478/testReport)** for PR 17770 at commit

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114928953 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark issue #17865: [SPARK-20456][Docs] Add examples for functions collectio...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17865 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17865: [SPARK-20456][Docs] Add examples for functions collectio...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17865 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76477/ Test FAILed. ---

[GitHub] spark issue #17865: [SPARK-20456][Docs] Add examples for functions collectio...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17865 **[Test build #76477 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76477/testReport)** for PR 17865 at commit

[GitHub] spark issue #17865: [SPARK-20456][Docs] Add examples for functions collectio...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17865 **[Test build #76477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76477/testReport)** for PR 17865 at commit

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114928655 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark issue #17865: [SPARK-20456][Docs] Add examples for functions collectio...

2017-05-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17865 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ...

2017-05-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17678 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76476/testReport)** for PR 17770 at commit

[GitHub] spark issue #17866: [SPARK-20605][Core][Yarn][Mesos] Deprecate not used AM a...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17866 **[Test build #76475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76475/testReport)** for PR 17866 at commit

[GitHub] spark pull request #17866: [SPARK-20605][Core][Yarn][Mesos] Deprecate not us...

2017-05-04 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/17866 [SPARK-20605][Core][Yarn][Mesos] Deprecate not used AM and executor port configuration ## What changes were proposed in this pull request? After SPARK-10997, client mode Netty RpcEnv

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76474/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76474/testReport)** for PR 17770 at commit

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread zero323
Github user zero323 closed the pull request at: https://github.com/apache/spark/pull/17825 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread zero323
GitHub user zero323 reopened a pull request: https://github.com/apache/spark/pull/17825 [SPARK-20550][SPARKR] R wrapper for Dataset.alias ## What changes were proposed in this pull request? - Add SparkR wrapper for `Dataset.alias`. - Adjust roxygen annotations for

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114925159 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76474/testReport)** for PR 17770 at commit

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76472/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76472/testReport)** for PR 17770 at commit

[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17300 **[Test build #76473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76473/testReport)** for PR 17300 at commit

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76472/testReport)** for PR 17770 at commit

[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-05-04 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17300 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17678 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76467/ Test FAILed. ---

[GitHub] spark issue #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17678 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance among ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17844 **[Test build #76471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76471/testReport)** for PR 17844 at commit

[GitHub] spark issue #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17678 **[Test build #76467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76467/testReport)** for PR 17678 at commit

[GitHub] spark pull request #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114924076 --- Diff: R/pkg/R/generics.R --- @@ -387,6 +387,16 @@ setGeneric("value", function(bcast) { standardGeneric("value") }) #' @export

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17770 @srinathshankar also thinks it's weird to add a barrier node. I suggest @hvanhovell and @srinathshankar duke it out. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #17825: [SPARK-20550][SPARKR] R wrapper for Dataset.alias

2017-05-04 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17825 could you close/reopen to trigger appveyor again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #17840: [SPARK-20574][ML] Allow Bucketizer to handle non-...

2017-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17840 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #76470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76470/testReport)** for PR 17770 at commit

[GitHub] spark pull request #17658: [SPARK-20355] Add per application spark version o...

2017-05-04 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/17658#discussion_r114924015 --- Diff: core/src/test/resources/HistoryServerExpectations/completed_app_list_json_expectation.json --- @@ -22,6 +23,7 @@ "duration" : 101795,

[GitHub] spark issue #17840: [SPARK-20574][ML] Allow Bucketizer to handle non-Double ...

2017-05-04 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/17840 Merged into master and branch-2.0. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17658: [SPARK-20355] Add per application spark version on the h...

2017-05-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17658 **[Test build #76469 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76469/testReport)** for PR 17658 at commit

[GitHub] spark issue #17865: [SPARK-20456][Docs] Add examples for functions collectio...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17865 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17865: [SPARK-20456][Docs] Add examples for functions collectio...

2017-05-04 Thread map222
Github user map222 commented on the issue: https://github.com/apache/spark/pull/17865 @HyukjinKwon I ended up not making examples for the aggregate functions, as I didn't make a good dataframe to demonstrate them. I could add more examples for the string functions if you think that

[GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...

2017-05-04 Thread map222
GitHub user map222 opened a pull request: https://github.com/apache/spark/pull/17865 [SPARK-20456][Docs] Add examples for functions collection for pyspark ## What changes were proposed in this pull request? This adds documentation to many functions in

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-05-04 Thread budde
Github user budde commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r114922000 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -60,12 +61,19 @@ private[kinesis] class

[GitHub] spark issue #17467: [SPARK-20140][DStream] Remove hardcoded kinesis retry wa...

2017-05-04 Thread budde
Github user budde commented on the issue: https://github.com/apache/spark/pull/17467 Fair enough. I took another look and I think I may have been thinking of the way things worked in an earlier revision of this code. I think the case class is reasonable. --- If your project is set

[GitHub] spark issue #17859: [SPARK-20595][Deploy]Parse the 'SPARK_EXECUTOR_INSTANCES...

2017-05-04 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17859 Ok, I will open another pr to remove it. Thanks a lot both of you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #17859: [SPARK-20595][Deploy]Parse the 'SPARK_EXECUTOR_IN...

2017-05-04 Thread ConeyLiu
Github user ConeyLiu closed the pull request at: https://github.com/apache/spark/pull/17859 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17658: [SPARK-20355] Add per application spark version o...

2017-05-04 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/17658#discussion_r114921697 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -283,10 +283,15 @@ private[spark] object EventLoggingListener

[GitHub] spark pull request #17658: [SPARK-20355] Add per application spark version o...

2017-05-04 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/17658#discussion_r114921013 --- Diff: core/src/test/resources/HistoryServerExpectations/completed_app_list_json_expectation.json --- @@ -22,6 +23,7 @@ "duration" : 101795,

[GitHub] spark issue #17819: [SPARK-20542][ML][SQL] Add a Bucketizer that can bin mul...

2017-05-04 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17819 Note: since in `Transformer`, there might be other manipulation to the dataset like dropping NaN values. The idea above won't work under that. --- If your project is set up for it, you can reply to

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-04 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17770 Thanks @rxin @marmbrus @hvanhovell @cloud-fan It is reasonable to me. I'll do eliminate the path of `resolveOperators`. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #17222: [SPARK-19439][PYSPARK][SQL] PySpark's registerJavaFuncti...

2017-05-04 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/spark/pull/17222 @cloud-fan This is not about using python UDF, it is to allow pyspark to use java UDF (no python daemon will be launched). So actually it would improve the performance. --- If your project is set

[GitHub] spark issue #17819: [SPARK-20542][ML][SQL] Add a Bucketizer that can bin mul...

2017-05-04 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17819 The bunch of projections will be collapsed in optimization. So it doesn't affect query execution. However, every `withColumn` call creates new `DataFrame` along with a projection on previous logical

[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-05-04 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/17300 Will merge when tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17222: [SPARK-19439][PYSPARK][SQL] PySpark's registerJavaFuncti...

2017-05-04 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17222 Hi @zjffdu thanks for working on it! But I'm not sure how useful this feature will be. AFAIK most users use scala/java UDF instead of Python UDF because it's too slow. We are working on a project

[GitHub] spark issue #17859: [SPARK-20595][Deploy]Parse the 'SPARK_EXECUTOR_INSTANCES...

2017-05-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17859 > Do we need remove the comments from template config? Ah, that would be a good idea. I also noticed it's still used in `YarnSparkHadoopUtil.scala`, so that could be removed too. I

[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-05-04 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17300 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17859: [SPARK-20595][Deploy]Parse the 'SPARK_EXECUTOR_INSTANCES...

2017-05-04 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17859 @vanzin Thanks a lot for you review. Do we need remove the comments from template config? It doesn't work anymore in current version. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #17658: [SPARK-20355] Add per application spark version on the h...

2017-05-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17658 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76466/ Test PASSed. ---

  1   2   3   4   5   >