Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21320
do we have comments other than code style issues? Generally we should not
block a PR just for code style issues, as long as the PR passes the style check.
---
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21830#discussion_r205338930
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1244,46 +1244,50 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21830#discussion_r205338428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1244,46 +1244,50 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20861#discussion_r205337069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1994,6 +1996,20 @@ class Analyzer(
}
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
@maryannxue as I said my initial proposal was like that. I think that this
has the advantage of avoiding some code duplication as the same logic which is
added in ResolveInValues has to be spread
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21830
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21830#discussion_r205336425
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1244,46 +1244,50 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21830#discussion_r205336334
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1244,46 +1244,50 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21306
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21306
**[Test build #93581 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93581/testReport)**
for PR 21306 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21306
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93581/
Test FAILed.
---
Github user ajacques commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r205329769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/SelectedField.scala
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the
Github user ajacques commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r205329633
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/ProjectionOverSchema.scala
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to
Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21320
@HyukjinKwon, I'm not totally familiar with Spark internals yet, so to be
honest I don't feel confident making big changes and hopefully can keep them
simple at first.
I've gone through
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21103
**[Test build #93582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93582/testReport)**
for PR 21103 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21103
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21103
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21875
@maryannxue It looks good to me. As a minor comment, could we state the
default value for this parameter as well ? For some of the other parameters, we
specify the default value.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21306
**[Test build #93581 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93581/testReport)**
for PR 21306 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21306
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21306
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93578/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21852
**[Test build #93578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93578/testReport)**
for PR 21852 at commit
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205331401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -52,7 +52,7 @@ trait CheckAnalysis extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21878
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93577/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21878
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21878
**[Test build #93577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93577/testReport)**
for PR 21878 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93576/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21852
**[Test build #93576 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93576/testReport)**
for PR 21852 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21789
Let me leave this open for few days in case some reviewers have more
comments on this.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21102
I agree with @ueshin's. I wouldn't make a guarantee of returning order here
in documentation yet though.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21867
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93574/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21867
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205325587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -52,7 +52,7 @@ trait CheckAnalysis extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21867
**[Test build #93574 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93574/testReport)**
for PR 21867 at commit
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/21789
@HyukjinKwon could you help to merge this to master branch? Thanks.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21758
**[Test build #93580 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93580/testReport)**
for PR 21758 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/21758
> What's the failure mode if there are not enough slots for the barrier
mode? We should throw an exception right?
Yes, as mentioned in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21875
Programming guide updated. Thank you, @dilipbiswal and @HyukjinKwon!
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21875
**[Test build #93579 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93579/testReport)**
for PR 21875 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21875
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21857
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93573/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21878
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93575/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21857
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21878
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21857
**[Test build #93573 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93573/testReport)**
for PR 21857 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21878
**[Test build #93575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93575/testReport)**
for PR 21878 at commit
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r205318258
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -359,20 +366,55 @@ private[spark] class TaskSchedulerImpl(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r205317494
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskInfo.scala ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21875
which is here
https://github.com/apache/spark/blob/master/docs/sql-programming-guide.md#jdbc-to-other-databases
---
-
To
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21867#discussion_r205312971
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -731,7 +731,14 @@ private[spark] class BlockManager(
}
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21650
ehh .. @BryanCutler, WDYT about just doing the previous one for now? The
approach you suggested sounds efficient of course but.. here's not a hot path
so I think the previous way is fine too ..
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r205311130
--- Diff: python/pyspark/sql/tests.py ---
@@ -5060,6 +5049,147 @@ def test_type_annotation(self):
df =
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21103#discussion_r205310335
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3805,3 +3799,330 @@ object ArrayUnion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r205309619
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,21 @@ object SimplifyConditionals
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21876
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93571/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21876
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21320
@ajacques, if you are willing to take over this, please go ahead. I would
appreciate it.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21320
@mallman and @ajacques, if you guys find it's any difficulty, I will take
over this. Please review this. Let me know if you guys think that's better way
to get through this.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21876
**[Test build #93571 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93571/testReport)**
for PR 21876 at commit
Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21320
Hey @mallman, I want to thank you for your work on this so far. I've been
watching this pull request hoping this would get merged into 2.4 since it would
be a benefit to me, but can see how it
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93570/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21221
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21221
**[Test build #93570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93570/testReport)**
for PR 21221 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21320
> After more than two years of off and on review, discussion/debate,
nitpicking, commits, steps forward and backwards, to have someone swoop in at
this time with a new raft of nitpicking and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/4
**[Test build #41 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/ubuntuSparkPRB/41/testReport)**
for PR 4 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21852
**[Test build #93578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93578/testReport)**
for PR 21852 at commit
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r205306098
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,22 @@ object SimplifyConditionals
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r205305691
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala
---
@@ -122,4 +126,25 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21878
**[Test build #93577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93577/testReport)**
for PR 21878 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21878
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21878
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r205303174
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala
---
@@ -122,4 +126,25 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r205303069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,22 @@ object SimplifyConditionals
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21821
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21596
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93569/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21596
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21596
**[Test build #93569 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93569/testReport)**
for PR 21596 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21852
**[Test build #93576 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93576/testReport)**
for PR 21852 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19528
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/21871
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21821
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21878
**[Test build #93575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93575/testReport)**
for PR 21878 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21878
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21878
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21878
cc @gengliangwang and @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/21878
[SPARK-24924][SQL] Add mapping for built-in Avro data source
## What changes were proposed in this pull request?
This PR aims to the followings.
1. Like
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21306
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93568/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21306
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21306
**[Test build #93568 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93568/testReport)**
for PR 21306 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21867
**[Test build #93574 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93574/testReport)**
for PR 21867 at commit
1 - 100 of 503 matches
Mail list logo
