[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220433980 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +153,56 @@ object EliminateOuterJoin extends

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220433916 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +153,56 @@ object EliminateOuterJoin extends

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96600/testReport)** for PR 22326 at commit

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220433940 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +153,56 @@ object EliminateOuterJoin extends

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220433995 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -165,6 +165,8 @@ abstract class

[GitHub] spark issue #21320: [SPARK-4502][SQL] Parquet nested column pruning - founda...

2018-09-25 Thread Gauravshah
Github user Gauravshah commented on the issue: https://github.com/apache/spark/pull/21320 @mallman any way I can help pull in rest of the changes from your original PR (https://github.com/apache/spark/pull/16578) for next release ? ---

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220433896 --- Diff: python/pyspark/sql/tests.py --- @@ -552,6 +552,92 @@ def test_udf_in_filter_on_top_of_join(self): df =

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220433190 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +153,56 @@ object EliminateOuterJoin extends

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96596/ Test FAILed. ---

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22419 **[Test build #96596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96596/testReport)** for PR 22419 at commit

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220432728 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -152,3 +153,56 @@ object EliminateOuterJoin extends

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220432468 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1304,10 +1307,27 @@ object

[GitHub] spark issue #22466: [SPARK-25464][SQL]On dropping the Database it will drop ...

2018-09-25 Thread sandeep-katta
Github user sandeep-katta commented on the issue: https://github.com/apache/spark/pull/22466 cc @cloud-fan @srowen I have updated the code,Please review --- - To unsubscribe, e-mail:

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22543 **[Test build #96599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96599/testReport)** for PR 22543 at commit

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22543 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96598/ Test FAILed. ---

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22543 **[Test build #96598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96598/testReport)** for PR 22543 at commit

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22326 Does it make sense to have a test case where the PythonUDF referencing attributes from both legs of join in disjunction with a regular predicate ? i.e joinCond = pythonUDF(leftattr, rightattr)

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22490 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22490 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96593/ Test FAILed. ---

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22490 **[Test build #96593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96593/testReport)** for PR 22490 at commit

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220428377 --- Diff: python/pyspark/sql/tests.py --- @@ -552,6 +552,92 @@ def test_udf_in_filter_on_top_of_join(self): df =

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220428290 --- Diff: python/pyspark/sql/tests.py --- @@ -552,6 +552,92 @@ def test_udf_in_filter_on_top_of_join(self): df =

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220428332 --- Diff: python/pyspark/sql/tests.py --- @@ -552,6 +552,92 @@ def test_udf_in_filter_on_top_of_join(self): df =

[GitHub] spark issue #22521: [SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIG...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96585/ Test FAILed. ---

[GitHub] spark issue #22521: [SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIG...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22521: [SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIG...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22521 **[Test build #96585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96585/testReport)** for PR 22521 at commit

[GitHub] spark issue #22549: [SPARK-25533][CORE][WEBUI]AppSummary should hold the inf...

2018-09-25 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22549 Hi @vanzin , The build has passed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22010 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96583/ Test PASSed. ---

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22010 **[Test build #96583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96583/testReport)** for PR 22010 at commit

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220424663 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1304,10 +1307,27 @@ object CheckCartesianProducts

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22543 **[Test build #96598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96598/testReport)** for PR 22543 at commit

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-25 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22362 @vanzin and @felixcheung can you please merge --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22543 **[Test build #96597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96597/testReport)** for PR 22543 at commit

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22543: [SPARK-23715][SQL][DOC] improve document for from/to_utc...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22325 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96581/ Test PASSed. ---

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22325 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22325 **[Test build #96581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96581/testReport)** for PR 22325 at commit

[GitHub] spark issue #22549: [SPARK-25533][CORE][WEBUI]AppSummary should hold the inf...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22549 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96582/ Test PASSed. ---

[GitHub] spark issue #22549: [SPARK-25533][CORE][WEBUI]AppSummary should hold the inf...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22549 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22549: [SPARK-25533][CORE][WEBUI]AppSummary should hold the inf...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22549 **[Test build #96582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96582/testReport)** for PR 22549 at commit

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220420622 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22419 **[Test build #96596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96596/testReport)** for PR 22419 at commit

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22419 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96587/ Test FAILed. ---

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22419 **[Test build #96587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96587/testReport)** for PR 22419 at commit

[GitHub] spark issue #22514: [SPARK-25271][SQL] Hive ctas commands should use data so...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22514 **[Test build #96595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96595/testReport)** for PR 22514 at commit

[GitHub] spark issue #22514: [SPARK-25271][SQL] Hive ctas commands should use data so...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22514 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22514: [SPARK-25271][SQL] Hive ctas commands should use data so...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22514 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22514: [SPARK-25271][SQL] Hive ctas commands should use data so...

2018-09-25 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22514 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220418201 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1304,10 +1307,27 @@ object

[GitHub] spark issue #22537: [SPARK-21291][R] add R partitionBy API in DataFrame

2018-09-25 Thread huaxingao
Github user huaxingao commented on the issue: https://github.com/apache/spark/pull/22537 Thanks! @HyukjinKwon @felixcheung --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22493: [SPARK-25485][SQL][TEST] Refactor UnsafeProjectionBenchm...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22493 **[Test build #96594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96594/testReport)** for PR 22493 at commit

[GitHub] spark issue #22192: [SPARK-24918][Core] Executor Plugin API

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22192 why do we merge a new API to branch-2.4, when RC1 is already out? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22490 **[Test build #96593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96593/testReport)** for PR 22490 at commit

[GitHub] spark issue #22489: [SPARK-25425][SQL][BACKPORT-2.3] Extra options should ov...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22489 **[Test build #96592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96592/testReport)** for PR 22489 at commit

[GitHub] spark issue #22520: [SPARK-25509][Core]Windows doesn't support POSIX permiss...

2018-09-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22520 I wouldn't worry unless it's been several days. Depending on urgency and impact, I leave some time before merging to make sure there aren't more comments. ---

[GitHub] spark pull request #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf fo...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22545#discussion_r220414608 --- Diff: python/pyspark/sql/context.py --- @@ -485,7 +485,8 @@ def __init__(self, sparkContext, jhiveContext=None):

[GitHub] spark issue #22489: [SPARK-25425][SQL][BACKPORT-2.3] Extra options should ov...

2018-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22489 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22520: [SPARK-25509][Core]Windows doesn't support POSIX permiss...

2018-09-25 Thread jianjianjiao
Github user jianjianjiao commented on the issue: https://github.com/apache/spark/pull/22520 @srowen @vanzin tests passed. What should I do now to make it approved to merge? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use...

2018-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22500#discussion_r220414353 --- Diff: sql/core/benchmarks/MiscBenchmark-results.txt --- @@ -0,0 +1,132 @@

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21632 **[Test build #96591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96591/testReport)** for PR 21632 at commit

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21632 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21632 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-09-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r220413827 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala --- @@ -700,6 +722,82 @@ class RandomForestSuite extends

[GitHub] spark pull request #21632: [SPARK-19591][ML][MLlib] Add sample weights to de...

2018-09-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/21632#discussion_r220413857 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala --- @@ -159,6 +169,31 @@ class

[GitHub] spark pull request #22490: [SPARK-25481][TEST] Refactor ColumnarBatchBenchma...

2018-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22490#discussion_r220413714 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchBenchmark.scala --- @@ -30,8 +30,15 @@ import

[GitHub] spark issue #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.writeLega...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22453 **[Test build #96590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96590/testReport)** for PR 22453 at commit

[GitHub] spark issue #22490: [SPARK-25481][TEST] Refactor ColumnarBatchBenchmark to u...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22490 **[Test build #96589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96589/testReport)** for PR 22490 at commit

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22545 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22490: [SPARK-25481][TEST] Refactor ColumnarBatchBenchmark to u...

2018-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22490 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21632 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21632 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22504: [SPARK-25118][Submit] Persist Driver Logs in Yarn Client...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22504 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22504: [SPARK-25118][Submit] Persist Driver Logs in Yarn Client...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22504 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96577/ Test FAILed. ---

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21632 **[Test build #96588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96588/testReport)** for PR 21632 at commit

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220412259 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark pull request #22429: [SPARK-25440][SQL] Dumping query execution info t...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22429#discussion_r220412301 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala --- @@ -167,6 +170,56 @@ package object util {

[GitHub] spark issue #22504: [SPARK-25118][Submit] Persist Driver Logs in Yarn Client...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22504 **[Test build #96577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96577/testReport)** for PR 22504 at commit

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22362 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22362 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96578/ Test PASSed. ---

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22362 **[Test build #96578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96578/testReport)** for PR 22362 at commit

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220411454 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220411333 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220411158 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220411054 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220410681 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220410505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark pull request #22543: [SPARK-23715][SQL][DOC] improve document for from...

2018-09-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220410457 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

  1   2   3   4   5   6   7   >