Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22698
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22698
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22645
I found the UI patches are very hard to review, because we embed
HTML/Javascript in Scala code. Is there a plan to rewrite the Spark UI with
some modern frontend frameworks?
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22702#discussion_r224950588
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -276,15 +276,31 @@ object BooleanSimplification
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22597
> In ParquetFilter, the way we test if a predicate pushdown works is by
removing that predicate from Spark SQL physical plan, and only relying on the
reader to do the filter.
I haven't
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r224949068
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -3854,6 +3854,38 @@ object functions {
@scala.annotation.varargs
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21993
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22702
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22702
Thanks! Merged to master/2.4/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21588
Yes it solves anything. We could consider to upgrade to Hive 3 but I am
unsure on this since any try (as far as I know) wasn't made yet. But for Hive
2.3.2, @wangyum made a try here
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22702
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97328/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22702
**[Test build #97328 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97328/testReport)**
for PR 22702 at commit
Github user mmolimar commented on a diff in the pull request:
https://github.com/apache/spark/pull/22383#discussion_r224948273
--- Diff: project/MimaExcludes.scala ---
@@ -36,6 +36,8 @@ object MimaExcludes {
// Exclude rules for 3.0.x
lazy val v30excludes =
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r224947824
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
---
@@ -67,6 +67,16 @@ private[sql] object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22699
**[Test build #4375 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4375/testReport)**
for PR 22699 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r224947556
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
---
@@ -67,6 +67,16 @@ private[sql] object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97329/testReport)**
for PR 22597 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97324/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #97324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97324/testReport)**
for PR 22381 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20761
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r224944923
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -108,6 +108,16 @@ object TestingUDT {
}
}
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20761
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22597
Thanks. I got it. You mean `stripSparkFilter` which is used in both
`OrcQuerySuite.scala` and `ParquetFilterSuite.scala`. Sure!
---
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/22703
I guess the only argument to the contrary would be if some of the known
issues end up being better solved with minor API changes, leaving it marked
as experimental would technically be
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22702
**[Test build #97328 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97328/testReport)**
for PR 22702 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22702
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97319/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97319/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22666
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22666
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97318/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22666
**[Test build #97318 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97318/testReport)**
for PR 22666 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22597
In `ParquetFilter`, the way we test if a predicate pushdown works is by
removing that predicate from Spark SQL physical plan, and only relying on the
reader to do the filter. Thus, if there is a bug
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22699
**[Test build #4375 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4375/testReport)**
for PR 22699 at commit
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/19045
please rename PR with [K8S] flag to launch tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22703#discussion_r224936431
--- Diff: docs/streaming-kafka-0-10-integration.md ---
@@ -3,7 +3,11 @@ layout: global
title: Spark Streaming + Kafka Integration Guide (Kafka broker
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22414
Yeah, the test that failed here asserts that it's an `AnalysisException`. I
guess it could be removed. The thing is, many other cases are still handled as
`AnalysisException`. Maybe it's best to
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22690
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22597
Thank you for review, @dbtsai and @gatorsmile .
BTW, what do you mean by removing? The pushed filter doesn't introduce
correctness issue like Parquet. Since it's a performance
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22661
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22690
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22661#discussion_r224934912
--- Diff: core/src/test/scala/org/apache/spark/benchmark/Benchmark.scala ---
@@ -200,11 +200,12 @@ private[spark] object Benchmark {
def
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22661#discussion_r224934704
--- Diff: sql/core/benchmarks/JoinBenchmark-results.txt ---
@@ -0,0 +1,75 @@
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22661#discussion_r224934660
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/JoinBenchmark.scala
---
@@ -19,229 +19,163 @@ package
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22597
Yes. Please add a test case.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97327/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #97327 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97327/testReport)**
for PR 19045 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22690
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22690
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97316/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #97327 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97327/testReport)**
for PR 19045 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22690
**[Test build #97316 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97316/testReport)**
for PR 22690 at commit
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/19045
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97326/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #97326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97326/testReport)**
for PR 19045 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22414
**[Test build #4374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4374/testReport)**
for PR 22414 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #97326 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97326/testReport)**
for PR 19045 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97317/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21710
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21710
**[Test build #97317 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97317/testReport)**
for PR 21710 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #97325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97325/testReport)**
for PR 19045 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97325/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #97325 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97325/testReport)**
for PR 19045 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22710
**[Test build #97323 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97323/testReport)**
for PR 22710 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22710
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22710
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97323/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #97324 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97324/testReport)**
for PR 22381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22710
**[Test build #97323 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97323/testReport)**
for PR 22710 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22710
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22503
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user squito reopened a pull request:
https://github.com/apache/spark/pull/22710
DO NOT MERGE
just for testing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/squito/spark blah
Alternatively you can review and apply these
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/22710
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97322/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #97322 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97322/testReport)**
for PR 19045 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19045
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #97322 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97322/testReport)**
for PR 19045 at commit
Github user szyszy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r224923768
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceRequestHelper.scala
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20761
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20761
**[Test build #97321 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97321/testReport)**
for PR 20761 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20761
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97321/
Test PASSed.
---
1 - 100 of 362 matches
Mail list logo
