Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22141
@maropu Very sorry. I haven't had the time to come back to it. I have some
stuff on my plate. I will get to this after i am done. Thanks !!
---
Github user weixiuli commented on the issue:
https://github.com/apache/spark/pull/23243
@HyukjinKwon OK ,thank you!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23243
Backport from which JIRA @weixiuli? Usually the fix should go to master
first and it's backported to other branches when it's needed. If it should be
fixed in master branch as well, let's file
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23241
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23241
**[Test build #99758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99758/testReport)**
for PR 23241 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/23241
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/23241
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22305
I can help if this looks good to @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23243
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23243
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23243
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user weixiuli opened a pull request:
https://github.com/apache/spark/pull/23243
add initRegisteredExecutorsDB
## What changes were proposed in this pull request?
As we all know that spark on Yarn uses DB to record RegisteredExecutors
information, when the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99752/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23207
**[Test build #99752 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99752/testReport)**
for PR 23207 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23223
**[Test build #99757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99757/testReport)**
for PR 23223 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23223
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99757/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23223
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23241
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99751/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23241
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23241
**[Test build #99751 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99751/testReport)**
for PR 23241 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23223
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23223
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23223#discussion_r239341126
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -612,11 +612,14 @@ private[yarn] class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23223
**[Test build #99757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99757/testReport)**
for PR 23223 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99756 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99756/testReport)**
for PR 23213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99748/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22612
**[Test build #99748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99748/testReport)**
for PR 22612 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23215
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23215
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23215
**[Test build #99755 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99755/testReport)**
for PR 23215 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99750/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wangjiaochun commented on the issue:
https://github.com/apache/spark/pull/23229
ok,close this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99750 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99750/testReport)**
for PR 23213 at commit
Github user wangjiaochun closed the pull request at:
https://github.com/apache/spark/pull/23229
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23141#discussion_r239333919
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -165,10 +165,14 @@ public void
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23215
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23215
**[Test build #99754 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99754/testReport)**
for PR 23215 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23215
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23215
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23215
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23215
**[Test build #99753 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99753/testReport)**
for PR 23215 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/23206
Today in Spark, the extension points API `injectOptimizerRule` method
allows the rules to be injected at the end in
`extendedOperatorOptimizationRules` and this becomes 2 batches separated by
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23206
What's a concrete example? IMHO the current proposed API is some
complicated/cumbersome to users and I feel its error-prone.
---
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/23206
@maropu, Thanks for your question. Yes. Thats correct.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23242
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23242
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user abellina opened a pull request:
https://github.com/apache/spark/pull/23242
SPARK-26285: accumulator metrics sources for LongAccumulator and Doubâ¦
â¦leAccumulator
## What changes were proposed in this pull request?
This PR implements metric sources
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23242
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r239323943
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -95,9 +77,116 @@ case class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22141
Any update?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21777
@kiszk Can you close this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99747/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23108
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23108
**[Test build #99747 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99747/testReport)**
for PR 23108 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r239319889
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -95,9 +77,116 @@ case class
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/23237
@HyukjinKwon Close this PR. Thank you!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user seancxmao closed the pull request at:
https://github.com/apache/spark/pull/23237
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23207
**[Test build #99752 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99752/testReport)**
for PR 23207 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23223#discussion_r239316608
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
---
@@ -417,4 +426,59 @@ class YarnAllocatorSuite
Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23223#discussion_r239316424
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
---
@@ -114,13 +116,20 @@ class YarnAllocatorSuite
Github user Ngone51 commented on the issue:
https://github.com/apache/spark/pull/23223
> it looks like its only going to blacklist the node for the AM, not other
nodes for general containers.
@squito Yarn have blacklist for AM when config
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23241
**[Test build #99751 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99751/testReport)**
for PR 23241 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23241
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user Ngone51 commented on the issue:
https://github.com/apache/spark/pull/23223
> Are you seeing actual issues with this blacklisting when it shouldn't?
Unfortunately, no. @tgravescs @squito
---
-
Github user Ngone51 commented on the issue:
https://github.com/apache/spark/pull/23223
> I mean if node blacklisting in Spark would be perfectly aligned to YARN
then it would be just redundant to have it in Spark in the first place.
This change seems result in *perfectly*
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239312302
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
---
@@ -144,24 +282,107 @@ case class WindowInPandasExec(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239307965
--- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
@@ -231,12 +266,10 @@ def test_array_type(self):
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239307779
--- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
@@ -87,8 +96,34 @@ def ordered_window(self):
def unpartitioned_window(self):
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239308506
--- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
@@ -245,11 +278,101 @@ def test_invalid_args(self):
foo_udf =
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22305#discussion_r239307483
--- Diff: python/pyspark/sql/tests/test_pandas_udf_window.py ---
@@ -44,9 +44,18 @@ def python_plus_one(self):
@property
def
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
Anyway, if we can accept the additional test time, I think it is the best
to run the tests on all the 4 patterns above for strict checks.
---
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239312090
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -170,13 +172,23 @@ class SQLMetricsSuite extends
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/23207
```
can you separate the prs to rename read side metric and the write side
change?
```
No problem, next commit will revert the changes of rename read side.
---
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239311564
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLShuffleMetricsReporter.scala
---
@@ -95,3 +96,59 @@ private[spark] object
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23237
Looks some classes, for instance, `KafkaUtils` exposes this (I guess
mistakenly?). Let's don't bother this and close this PR.
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23206
cc: @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23206
The current post hook is not enough for the use case you assume?
---
-
To unsubscribe, e-mail:
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239311141
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -38,12 +38,18 @@ case class CollectLimitExec(limit: Int, child:
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239311018
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -38,12 +38,18 @@ case class CollectLimitExec(limit: Int, child:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23213
I think so, don't know if @cloud-fan or @mgaido91 has other opinions?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23237
**[Test build #99749 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99749/testReport)**
for PR 23237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99749/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23237
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/23241
Thanks @vanzin I updated the title
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99750 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99750/testReport)**
for PR 23213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 614 matches
Mail list logo
