Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22813
@ouyangxiaochen . Sorry, but the use case sounds like a misconfiguration.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22830#discussion_r228800501
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -163,8 +163,6 @@ class LogisticRegressionModel
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22830
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22851
Thank you, @seancxmao and @felixcheung .
@seancxmao . Please close this PR since it's merged now
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22851
Merged to `branch-2.3`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22861
At least, the following is worth for a separate PR because it's orthogonal
`Refactor ... to use main method`.
```
1. Make mainArgs correctly set in BenchmarkBase.
```
One
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22514
I see. Thank you for confirmation, @gatorsmile and @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22514
Also, cc @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22817
Thank you, @gatorsmile !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22514
This PR will resolve a regression which is throwing
`java.lang.RuntimeException` for Parquet tables. I'm wondering if we can
consider this for 2.4.0 RC5
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r228772854
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2648,7 +2648,7 @@ class DataFrameFunctionsSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r228772799
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -21,7 +21,6 @@ import java.net.URI
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r228772719
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSuite.scala ---
@@ -92,4 +92,18 @@ class HiveParquetSuite extends QueryTest
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22856#discussion_r228771390
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
---
@@ -23,9 +23,21 @@ import
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22788#discussion_r228770171
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2856,6 +2856,21 @@ class SQLQuerySuite extends QueryTest
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22617#discussion_r228768273
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArrayBenchmark.scala
---
@@ -68,9 +100,7 @@ object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r228760320
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -83,6 +83,7 @@ abstract class Optimizer
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r228760200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -736,3 +736,65 @@ object CombineConcats
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r228760023
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceNullWithFalseSuite.scala
---
@@ -0,0 +1,324
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r228755710
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22865#discussion_r228755473
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -462,7 +462,7 @@ object SQLConf {
val
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19601
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22843#discussion_r228616400
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3477,39 +3447,6 @@ test_that("Window functions on a DataFrame", {
expect_eq
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22823#discussion_r228605621
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BenchmarkWideTable.scala
---
@@ -1,52 +0,0 @@
-/*
- * Licensed
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22844
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22845
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22840
Oops. My bad. I'll monitor the branch.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22823#discussion_r228400706
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BenchmarkWideTable.scala
---
@@ -1,52 +0,0 @@
-/*
- * Licensed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22823#discussion_r228399871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -910,12 +910,14 @@ class
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/22837
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22837
Merged to `branch-2.4`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22837
Thank you for review and approval, @HyukjinKwon !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22837
Could you review this, @HyukjinKwon ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22840
Thank you, @srowen and @HyukjinKwon .
Merged to master/branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22840
@srowen . It's a documented feature.
-
http://spark.apache.org/docs/latest/building-spark.html#building-a-runnable-distribution
I know that you're not against it, but Spark 2.4.0
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22840
I noted that this doesn't aim to reproduce the provided binary release.
This aims to help individual contributor participate to test the source
artifacts during voting phase
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/22839
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22839
Thank you so much for review, @dbtsai .
Merged to `branch-2.4`.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22840
cc @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22840
[SPARK-25840][BUILD] `make-distribution.sh` should not fail due to missing
LICENSE-binary
## What changes were proposed in this pull request?
We vote for the artifacts. All releases
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22838#discussion_r228313490
--- Diff: pom.xml ---
@@ -2654,6 +2654,16 @@
kubernetes
+
+resource-managers/kubernetes/core
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22839#discussion_r228307486
--- Diff: docs/sql-data-sources-load-save-functions.md ---
@@ -82,6 +82,49 @@ To load a CSV file you can use:
+The extra options
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22839#discussion_r228307138
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -114,10 +114,14 @@ write.df(namesAndAges, "namesAndAges.parquet",
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22839
[SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc and examples about
extra data source options
## What changes were proposed in this pull request?
Our current doc does
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22823#discussion_r228295120
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -910,12 +910,14 @@ class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22827
@gatorsmile . Could you put `[BRANCH-2.4]` into PR title?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22837#discussion_r228293689
--- Diff: sql/core/src/test/resources/sql-tests/results/datetime.sql.out ---
@@ -82,9 +82,10 @@ struct
1 2
2 3
+
-- !query
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22837
[MINOR][TEST] Fix datetime.sql.out
## What changes were proposed in this pull request?
`datetime.sql.out` is a generated golden file, but it's a little bit broken
during manual
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22827#discussion_r228269628
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/higher-order-functions.sql ---
@@ -60,8 +60,3 @@ select zip_with(array('a', 'b', 'c'), array
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22827#discussion_r228267271
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/higher-order-functions.sql ---
@@ -60,8 +60,3 @@ select zip_with(array('a', 'b', 'c'), array
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22827
Also, please remove `public static final int WORD_SIZE = 8;` in
UnsafeRow.java. It's added by `map_entries`.
-
https://github.com/apache/spark/pull/22828/files?utf8=%E2%9C%93=unified=1
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22827#discussion_r228263430
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/higher-order-functions.sql ---
@@ -65,21 +65,3 @@ create or replace temporary view nested
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22828
Oh, I'm closing this in favor of https://github.com/apache/spark/pull/22827.
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/22828
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22828
To run the Jenkins faster, I create a standalone PR instead of making a PR
to #22821 .
---
-
To unsubscribe, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22828#discussion_r228259220
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -61,8 +61,6 @@
*/
public final class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22828#discussion_r228258092
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -433,13 +432,9 @@ object FunctionRegistry
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22828#discussion_r228257902
--- Diff: python/pyspark/sql/functions.py ---
@@ -2540,26 +2540,6 @@ def map_values(col):
return Column(sc._jvm.functions.map_values
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22828#discussion_r228257685
--- Diff: R/pkg/NAMESPACE ---
@@ -313,7 +313,6 @@ exportMethods("%<=>%",
"lower"
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22828
[SPARK-25832][SQL] remove newly added map related functions
## What changes were proposed in this pull request?
This aims to supercede https://github.com/apache/spark/pull/22821
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22821#discussion_r228230625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -414,7 +414,6 @@ object FunctionRegistry
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22821#discussion_r228230052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -414,7 +414,6 @@ object FunctionRegistry
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22821#discussion_r228227982
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -414,7 +414,6 @@ object FunctionRegistry
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22821
@cloud-fan . I'll update my PR to you once more.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22821
Thank you, @rxin . In that case, +1 for complete removal.
It's easier for us to add the expressions back instead of updating exising
expressions
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22821
I'm just confused here. Shall we finish the discussion on the email thread?
@cloud-fan and @gatorsmile . If the decision is officially made like that
(providing tech. preview to advance users
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22821
@cloud-fan . That's sounds like a Tech. Preview for the advance users,
doesn't it?
It looks like an excuse to ignore the whole context of the discussion and
to try to ship in any way
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22819
Could you add https://github.com/apache/spark/pull/20405, too?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22811
Hi, @un-knower . Could you close this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21859#discussion_r227592853
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SmallDataSortBenchmark.scala
---
@@ -0,0 +1,105
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19601
Hi, @kiszk . Can we close this for now? You can make another PR later if
you want.
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17174
@maropu . +1 for your idea.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16478
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22663
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22804#discussion_r227582826
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/execution/benchmark/ObjectHashAggregateExecBenchmark.scala
---
@@ -21,207 +21,212 @@ import
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22771
`PagedTableSuite.pageNavigation` failure is fixed in the master.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22771
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22804
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22788
@viirya . Please see the all four examples. I guess you missed the context.
- https://github.com/apache/spark/pull/22788#pullrequestreview-166797320
BTW, I'm good for any methods
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22801
Thank you for review, @felixcheung , @dbtsai , @HyukjinKwon .
Merged to master.
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22808
Thank you, @gengliangwang and @felixcheung .
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22791#discussion_r227493674
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -114,7 +114,7 @@ write.df(namesAndAges, "namesAndAges.parquet",
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22791#discussion_r227493317
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -114,7 +114,7 @@ write.df(namesAndAges, "namesAndAges.parquet",
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22801#discussion_r227478986
--- Diff: examples/src/main/python/sql/datasource.py ---
@@ -57,6 +57,15 @@ def basic_datasource_example(spark):
format
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22801#discussion_r227478845
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -118,6 +118,10 @@ df <-
read.df("examples/src/main/resources/people.csv"
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22801#discussion_r227457282
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -118,6 +118,10 @@ df <-
read.df("examples/src/main/resources/people.csv"
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22801#discussion_r227434947
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/SQLDataSourceExample.scala
---
@@ -56,6 +56,13 @@ object SQLDataSourceExample
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22801#discussion_r227226704
--- Diff: docs/sql-data-sources-load-save-functions.md ---
@@ -82,6 +82,50 @@ To load a CSV file you can use:
+The extra options
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22801
[SPARK-25656][DOC][EXAMPLE] Add a doc and examples about extra data source
options
## What changes were proposed in this pull request?
Our current doc does not explain how we
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22790
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22788
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22791
Thank you for review and merging, @srowen .
Merged to `master/branch-2.4/branch-2.3`.
---
-
To unsubscribe, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22796
Removing the depedency is good, but currently
- It's not clear the effective benefit for Apache Spark by downgrading the
dependency in the distribution.
- Downgrading in binary
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22790#discussion_r227152309
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
---
@@ -126,7 +126,7 @@ object BisectingKMeansModel
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22788#discussion_r227093538
--- Diff:
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out
---
@@ -81,7 +81,7 @@ SELECT t1.i1 FROM t1, mydb1.t1
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22796
Hi, @lipzhu . Could you close this PR and SPARK-25800 issue?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22796#discussion_r227043052
--- Diff: dev/deps/spark-deps-hadoop-2.7 ---
@@ -148,7 +148,7 @@ metrics-graphite-3.1.5.jar
metrics-json-3.1.5.jar
metrics-jvm-3.1.5.jar
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22791#discussion_r227041945
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -114,7 +114,7 @@ write.df(namesAndAges, "namesAndAges.parquet",
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22791#discussion_r227014553
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -114,7 +114,7 @@ write.df(namesAndAges, "namesAndAges.parquet",
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/22792
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
401 - 500 of 7331 matches
Mail list logo
