Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22302
@fjh100456 Can you format the PR description cleanly to make others more
understood?
---
-
To unsubscribe, e-mail: reviews
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22302
@gatorsmile @ueshin Can you trigger this? I checked the related jira and
code and, then I think these tests should be passed in master when
`usingCTAS`=true
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22270#discussion_r214500639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,12 +1465,14 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r214492145
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -48,6 +48,8 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r214491914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -48,6 +48,8 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214491144
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -229,36 +229,74 @@ case class RLike(left
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r214490061
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -73,6 +75,29 @@ class ExecutorSource(threadPool: ThreadPoolExecutor
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r214489886
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -73,6 +75,29 @@ class ExecutorSource(threadPool: ThreadPoolExecutor
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r214489390
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -73,6 +75,29 @@ class ExecutorSource(threadPool: ThreadPoolExecutor
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22270#discussion_r214351711
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,12 +1465,14 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22270#discussion_r214341661
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -85,12 +85,12 @@ class DataFrameFunctionsSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22270#discussion_r214340187
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -1730,9 +1730,8 @@ class DataFrameSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22270#discussion_r214338698
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,12 +1465,14 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22270#discussion_r214338655
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,12 +1465,14 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22284#discussion_r214311017
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/QueryPlanner.scala
---
@@ -81,7 +81,7 @@ abstract class QueryPlanner
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22284#discussion_r214300480
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/QueryPlanner.scala
---
@@ -81,7 +81,7 @@ abstract class QueryPlanner
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22300#discussion_r214266047
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22048
+1 for adding `scalastyle:off nonascii` in that part.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22048
style errors, we cannot include non-ascii characters in files;
```
Scalastyle checks failed at following occurrences:
[error]
/home/jenkins/workspace/NewSparkPullRequestBuilder@2/core/src
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22284#discussion_r214227657
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -497,6 +497,17 @@ class SQLMetricsSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22284#discussion_r214227423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/QueryPlanner.scala
---
@@ -81,7 +81,7 @@ abstract class QueryPlanner
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r214218549
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -469,4 +470,26 @@ class JsonFunctionsSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22264#discussion_r214215448
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -290,6 +290,16 @@ object QueryTest {
Row.fromSeq(row.toSeq.map
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/7
You need to handle that in both codegen(doGenCode) and
interpreter(nullSafeEval) path. Also, can you add tests to check if they have
the same behaviour in the limit=0/limit=-1 cases? You'd be better
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22264
`in 2.12` -> `in Scala 2.12` in the title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additio
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22264#discussion_r214044804
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -290,6 +290,16 @@ object QueryTest {
Row.fromSeq(row.toSeq.map
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r214007983
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -52,4 +52,21 @@ class RewriteSubquerySuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r214005837
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21790#discussion_r213997672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala
---
@@ -40,10 +40,11 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21790#discussion_r213997220
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala
---
@@ -40,10 +40,11 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21790#discussion_r213996010
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -36,6 +36,7 @@ import
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21790
Also, you need to add tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21790
@caneGuy Can you fix the title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21790
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r213988466
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/nested-not-in.sql
---
@@ -0,0 +1,198 @@
+-- Tests NOT-IN subqueries nested
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r213980110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,28 @@ case class JsonToStructs
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22204
Also, we might be able to extend the ANALYZE command for this purpose.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22204
ah, how about adding a new method in `SparkSession` e.g.,
`SparkSession.analyzeColumnCacheQuery`?
---
-
To unsubscribe, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22263#discussion_r213904343
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -162,7 +162,8 @@ statement
tableIdentifier
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22276
oh, yes, this is the issue of binary compatibility...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22260
LGTM, too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r213886899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala
---
@@ -15,50 +15,51 @@
* limitations under
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r213885777
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,28 @@ case class JsonToStructs
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r213885328
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,28 @@ case class JsonToStructs
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu Are u there?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
Aha, I see. It is simple to match identifiers literally. So, let me wait
for other developers comments. cc: @gatorsmile
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22204
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22276
You need to update `project/MimaExcludes.scala` in this case. Either way,
we cannot touch stable interfaces now. I think you need to wait for branch-2.4
cut
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213869119
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2794,6 +2794,27 @@ private[spark] object Utils extends Logging
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213868352
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2794,6 +2794,27 @@ private[spark] object Utils extends Logging
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22048
Also, can you add tests in `DatasetSuite`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22232#discussion_r213543748
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceSuite.scala
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@HyukjinKwon can you trigger again?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/7
Also, you need to update split in python and R.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r213540571
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -229,33 +229,59 @@ case class RLike(left
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r213539793
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -229,33 +229,59 @@ case class RLike(left
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r213539767
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -229,33 +229,59 @@ case class RLike(left
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r213538271
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -229,33 +229,59 @@ case class RLike(left
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r213538010
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -229,33 +229,59 @@ case class RLike(left
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213537514
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -294,23 +294,29 @@ class Dataset[T] private[sql](
// We set a minimum
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213537463
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -294,23 +294,29 @@ class Dataset[T] private[sql](
// We set a minimum
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213537424
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -294,23 +294,29 @@ class Dataset[T] private[sql](
// We set a minimum
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22260
Can you add `[SQL][MINOR]` in the title? Also, can you narrow down the
tittle cuz it is a little obscure.
---
-
To unsubscribe
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22260#discussion_r213536395
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ProjectionOverSchema.scala
---
@@ -38,7 +38,7 @@ private[execution] case class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
Thanks for the sum-up. I like simpler one, too. Le me just describe more to
make me more understood; IIUC we have the two case: (1) fully-qualified case
`/*+ MAPJOIN(testDb.t) */` and (2) non
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20965
ok, I stop this work. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r213274849
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -950,6 +950,15 @@ object SQLConf {
.booleanConf
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20965
oh, made a mistake ...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21790
sure, I'll check later.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22198#discussion_r213197519
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
---
@@ -47,20 +49,47 @@ object ResolveHints
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22162#discussion_r213158510
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -815,6 +815,24 @@ class Dataset[T] private[sql](
println(showString
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22162#discussion_r213158056
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22162
ya, sure.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22162#discussion_r213157406
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -815,6 +815,24 @@ class Dataset[T] private[sql](
println(showString
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r213154483
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -5,6 +5,10 @@ select format_string();
-- A pipe operator for string
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22162
I have much bandwidh to take it, too. Is it ok to take it over? @mgaido91
not working on this now?
---
-
To unsubscribe, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21968
The change looks reasonable to me, so can you trigger tests? @gatorsmile
@cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r212959634
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -141,9 +141,6 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r212956571
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -48,6 +48,8 @@ class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/6
Probably, you'd be better to file separate jira for each function.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6#discussion_r212918991
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -51,3 +51,8 @@ select from_json('[null, {"a":2}]
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6#discussion_r212918588
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala
---
@@ -32,29 +32,29 @@ object JacksonUtils
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6#discussion_r212917164
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -65,6 +66,8 @@ private[sql] class JacksonGenerator
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/6
@MaxGekk btw, why did you attach this pr to the resolved jira?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22241#discussion_r212901257
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashMapSuite.scala ---
@@ -194,4 +194,42 @@ class OpenHashMapSuite extends SparkFunSuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22241#discussion_r212894122
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashMapSuite.scala ---
@@ -194,4 +194,42 @@ class OpenHashMapSuite extends SparkFunSuite
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22241
plz add `[CORE]` in the title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r212891660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala
---
@@ -15,50 +15,51 @@
* limitations under
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r212887790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,22 @@ case class JsonToStructs
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22198#discussion_r212861566
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
---
@@ -47,20 +49,39 @@ object ResolveHints
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r212857658
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,47 @@ case class HashAggregateExec
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r212854595
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,47 @@ case class HashAggregateExec
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21860
In the description, can you simplify the example query? e.g.,
```
import org.apache.spark.sql.execution.debug._
spark.range(1).selectExpr("id AS key", "id AS
value"
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22239
Better to add `in global limit` in the title?
Anyway, LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22198#discussion_r212851693
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
---
@@ -47,20 +49,39 @@ object ResolveHints
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22198#discussion_r212850203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
---
@@ -47,20 +49,39 @@ object ResolveHints
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22198#discussion_r212844578
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
---
@@ -47,20 +49,39 @@ object ResolveHints
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22198#discussion_r212844390
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -144,7 +144,7 @@ class Analyzer(
lazy val
401 - 500 of 3605 matches
Mail list logo
