Github user rednaxelafx commented on the pull request:
https://github.com/apache/spark/pull/7789#issuecomment-126214413
Yes, this change looks good to me, for a semantically safe bet on the
object layout.
---
If your project is set up for it, you can reply to this email and have
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/1
[SPARK-20482][SQL] Resolving Casts is too strict on having time zone set
## What changes were proposed in this pull request?
Relax the requirement that a `TimeZoneAwareExpression` has
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r113589540
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -165,6 +165,22 @@ case class Cast(child: Expression
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r113589853
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -165,6 +165,22 @@ case class Cast(child: Expression
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/1
I'll update again to address comments from @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r113751468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -165,6 +181,14 @@ case class Cast(child: Expression
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r113751399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -89,6 +89,22 @@ object Cast {
case
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/1
Thanks for the review! I'll update the patch again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rednaxelafx closed the pull request at:
https://github.com/apache/spark/pull/18255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/15227#discussion_r123054373
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -129,11 +131,17 @@ class
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/18095
[SPARK-20872][SQL] ShuffleExchange.nodeName should handle null coordinator
## What changes were proposed in this pull request?
A one-liner change in `ShuffleExchange.nodeName` to cover
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/18095#discussion_r118382726
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchange.scala
---
@@ -40,14 +40,17 @@ case class ShuffleExchange
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/18257
The end result looks good to me. Thanks for fixing it!
Although, I'd prefer fixing the actual integer overflow handling in
`RangeExec`'s codegen, too. Even though your fix will handle
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/18255
[SPARK-21038][SQL] Reduce redundant generated init code in Catalyst codegen
## What changes were proposed in this pull request?
In Java, instance fields are guaranteed to be first
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/18095#discussion_r118359189
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchange.scala
---
@@ -47,7 +47,7 @@ case class ShuffleExchange
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/18095
Updated patch to address the comments on making two other match conditions
on `coordinator` so that they're consistently handled.
---
If your project is set up for it, you can reply
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19488#discussion_r144651235
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -205,14 +205,17 @@ object PhysicalAggregation
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135988601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1091,6 +,7 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135985618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135989181
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -176,34 +176,46 @@ class WholeStageCodegenSuite
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r135996601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19082#discussion_r136506452
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -244,6 +246,92 @@ case class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19082#discussion_r136506046
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -244,6 +246,92 @@ case class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136250152
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/19890
I'd LGTM on both upgrading to Janino 3.0.8 and also changing the exception
type captured from `JaninoRuntimeException` to the new
`InternalCompilerException`. It's never a good idea to have
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189229566
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -0,0 +1,130
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189225184
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,115 @@ object JavaCode
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189229229
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -0,0 +1,130
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/21106
Should this PR wait for https://github.com/apache/spark/pull/21299 so that
accessing confs on executors can be made simpler
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21367#discussion_r189723394
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -297,13 +279,39 @@ case class Divide(left
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21367#discussion_r189404152
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -220,30 +220,12 @@ case class Multiply(left
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189785968
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -23,12 +23,20 @@ import
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r189786155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -167,9 +170,40 @@ object Block
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/21367
Updated PR, addressed @cloud-fan and @viirya 's comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/21367
[SPARK-24321][SQL] Extract common code from Divide/Remainder to a base trait
## What changes were proposed in this pull request?
Extract common code from `Divide`/`Remainder` to a new
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/21643
Thanks for your comments, @MaxGekk @maropu @cloud-fan , I've tweaked the
unit test case to address your comments. Please check it out again
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/21643
https://github.com/apache/spark/pull/21643#pullrequestreview-131977512
For all practical purposes, no, this change shouldn't break any use cases
that we support; there could be use cases
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21643#discussion_r198268691
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ComplexDataSuite.scala
---
@@ -104,4 +104,38 @@ class ComplexDataSuite
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21643#discussion_r198370477
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ComplexDataSuite.scala
---
@@ -104,4 +104,40 @@ class ComplexDataSuite
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/21643
[SPARK-24659][SQL] GenericArrayData.equals should respect element type
differences
## What changes were proposed in this pull request?
Fix `GenericArrayData.equals`, so
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/20163
[SPARK-22966][PySpark] Spark SQL should handle Python UDFs that return a
datetime.date or datetime.datetime
## What changes were proposed in this pull request?
Perform appropriate
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/20158
Fix typo in comments in PySpark's udf() definition
## What changes were proposed in this pull request?
Just a simple typo fix from `curcuiting` to `circuiting`.
## How
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20158
@srowen Thanks for your review! I'll have a look at other typos and update
this PR later.
I was actually working on code around this place and thought I'd split out
the typo fix
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20163
Thanks for all of your comments, @HyukjinKwon and @icexelloss !
I'd like to wait for more discussions / suggestions on whether or not we
want a behavior change that makes this reproducer
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/20224
[SPARK-23032][SQL] Add a per-query codegenStageId to WholeStageCodegenExec
## What changes were proposed in this pull request?
**Proposal**
Add a per-query ID to the codegen
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
One comment as to using `ThreadLocal[Integer]` for keeping track of the
IDs: I did have an alternative implementation of this PR that declares
`WholeStageCodegenExec` as:
```scala
case
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20163
Given the above discussion, do we have consensus on all of the following:
- Update the documentation for PySpark UDFs to warn about the behavior of
mismatched declared `returnType` vs actual
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
I've updated the PR addressing @gatorsmile 's comments: moved the new
utility code to `WholeStageCodegenId` object and added a new test case in
`HiveExplainSuite`.
ping @gatorsmile
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r164019336
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -471,19 +531,21 @@ case class
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20158
@HyukjinKwon cool! Thanks a lot for including it! Closing this one now.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user rednaxelafx closed the pull request at:
https://github.com/apache/spark/pull/20158
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r161979484
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -312,6 +313,24 @@ case class InputAdapter(child
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Thanks @gatorsmile ! Will add a new test case in `HiveExplainSuite`.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r161980740
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -575,7 +609,10 @@ case class CollapseCodegenStages
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163757952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -325,6 +326,28 @@ object WholeStageCodegenExec
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163757687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -629,6 +629,13 @@ object SQLConf {
.booleanConf
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163771262
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,35 @@ class WholeStageCodegenSuite
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Updated the PR:
1. addressed @cloud-fan 's comment to make sure the `codegenStageId` is
properly copied in transformations after `CollapseCodegenStages`. Added a new
unit test case
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163947756
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -471,19 +531,21 @@ case class
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Updated again. Addressed @viirya 's comments:
1. added comments to explain where this codegen stage ID is used
2. moved an assertion message to a comment
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163784607
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,35 @@ class WholeStageCodegenSuite
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163784286
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -325,6 +326,32 @@ object WholeStageCodegenExec
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163799937
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -228,4 +229,38 @@ class WholeStageCodegenSuite
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Updated again to address @cloud-fan 's comments: removed unneeded test case
and added a bit more comments
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20163#discussion_r161287717
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala
---
@@ -144,6 +145,7 @@ object EvaluatePython
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20247
Thanks for fixing it!
One thing I'm curious what others think is, whether or not the
`AnalysisBarrier` nodes themselves should show up in the explain output at all,
i.e. should
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Thanks for your comments and questions, @kiszk and @maropu !
Let me address them in a couple of separate points.
**tl;dr**
On top of my original proposal in the PR
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20224
Thanks for your comments, @viirya !
I'd say only having (1) and (2) makes it much less useful than having all
3, but it's still useful in its own for helping people understand exactly
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20163
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20419
@kiszk SGTM and LGTM. Let's ship it!
One more question on the side: with the `forceComment = true`, are we fully
sure that won't affect the equality of `CodeAndComment`?
The whole
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20419
@gatorsmile Not directly. The `CodeAndComment` case class is just a
"container", it doesn't handle what gets into the `body` field. When we force
embed a comment, it'll leave
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20419
LGTM, and +1 on @viirya 's idea. I like it better for the comment to be on
top of the class declaration instead of inside it; but I'm okay either way if
others have strong opinion otherwise
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20419
@kiszk For this specific kind of usage, I don't think using a hardcoded
stable ID will be a problem.
The comment we're talking about is the kind the can only appear once in a
single whole
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20419
I did the experiment that I asked about at
https://github.com/apache/spark/pull/20419#issuecomment-361359825 , and
verified that under the current implementation, this PR will not affect
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20419
I gave it a bit more thought. Here's an alternative proposal: instead of
using a "force comment" mechanism in the current form (which still gets a
`ctx.freshName("c")`
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20434#discussion_r164687283
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -660,12 +660,10 @@ object SQLConf {
val
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r167775177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1226,14 +1226,21 @@ class
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20599#discussion_r168101849
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -675,6 +675,16 @@ object SQLConf {
"disable lo
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20626
cc @cloud-fan @hvanhovell
Note: this is for master and branch-2.3 post 2.3.0 release.
---
-
To unsubscribe, e-mail
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/20626
[SPARK-23447][SQL] Cleanup codegen template for Literal
## What changes were proposed in this pull request?
Cleaned up the codegen templates for `Literal`s, to make sure
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20626
So I was able to find quite a few cases where the `DUMMY` placeholder
caught uses of the `value` field outside of appropriate null-checked regions.
I'll check the individual cases
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20626
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20626
Ah...I see, there are more places where they're statically referencing some
variable but dynamically those variables would always be null. I'll update the
PR later to fix those places as well
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20626
@hvanhovell Thanks a lot! You're absolutely right. Update the PR
accordingly. It's passing tests in my local testing and hopefully it'll pass
the Jenkins tests as well
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20043
Hi @viirya, this PR is definitely onto the right direction. I'd like to
review this PR as well and hopeful help polish it in for post-2.3. Thanks for
your work
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20612
LGTM. Let's wait for one more LGTM from @gatorsmile / @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20645
A quick question: after this change, `extraJavaOptions` is still able to
cleanly override whatever's set in `defaultJavaOptions`, is that right?
^^ Just making sure I understood
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/21951
LGTM as well. Thanks a lot!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/22103
[SPARK-25113][SQL] Add logging to CodeGenerator when any generated method's
bytecode size goes above HugeMethodLimit
## What changes were proposed in this pull request?
Add logging
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22103#discussion_r210129972
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1385,9 +1386,15 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22103#discussion_r210130579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1385,9 +1386,15 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22103#discussion_r210169785
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1385,9 +1386,15 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211485314
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -40,4 +55,13
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211485848
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -63,7 +49,10
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211484515
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -180,7 +180,10 @@ object UnsafeProjection
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211487231
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -40,4 +55,13
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211484616
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -180,7 +180,10 @@ object UnsafeProjection
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211485732
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -40,4 +55,13
1 - 100 of 159 matches
Mail list logo
