Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23272#discussion_r240146031
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -255,11 +255,18 @@ private MapIterator(int numRecords, Location
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23272#discussion_r240144674
--- Diff:
core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
---
@@ -667,4 +668,53 @@ public void testPeakMemoryUsed
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23269
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23271
cc @rxin and @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23271#discussion_r240115920
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
@@ -58,8 +58,21 @@ object Row {
* Merge multiple rows into a single
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23271
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/23270
[SPARK-26317][BUILD] Upgrade SBT to 0.13.18
## What changes were proposed in this pull request?
SBT 0.13.14 ~ 1.1.1 has a bug on accessing `java.util.Base64.getDecoder` on
JDK9
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23269
@JkSelf . Since PR description already mentioned the background and the
partital revert stuff, could you update the PR title to describe your solution
more directly? `partial revert` doesn't
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23269
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23225
Thank you, @wangjiaochun .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23072
It looks enough to me, @srowen .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23225
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23267
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23266#discussion_r240053406
--- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java
---
@@ -18,9 +18,6 @@
package org.apache.spark.sql.sources.v2
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23253#discussion_r240048780
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/BadRecordException.scala
---
@@ -20,6 +20,16 @@ package
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan and @JkSelf .
For the partial revert, we had better create a new Apache JIRA issue. That
will be a more cleaner way to backport
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23142
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r240022467
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSourceSuite.scala
---
@@ -222,4 +222,61 @@ class HiveParquetSourceSuite
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23142
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23204
Hi, @LuciferYang . If we are not going to revert this, could you close this
PR?
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23238
Thanks, @seancxmao .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23238
Merged to master and branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23253
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23259
cc @hvanhovell , @mgaido91 , too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23259
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r240014393
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
---
@@ -190,4 +192,103 @@ class HiveOrcSourceSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r240014126
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -235,11 +235,8 @@ public void writeEmptyIterator
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23239
Hi, @cloud-fan . Please make another PR for `branch-2.4`. There is a
conflict on `branch-2.4`.
---
-
To unsubscribe, e
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23253#discussion_r240013729
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -37,6 +37,8 @@ displayTitle: Spark SQL Upgrading Guide
- In Spark version 2.4
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23264
This is merged now. Please close the PR, @srowen . :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23264
Merged to branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23218
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23218
@shaneknapp .
The above run is still using old one. Do we need to retrigger to use
JDK8_191?
```
[info] Building Spark (w/Hive 1.2.1) using SBT with these arguments:
-Phadoop-2.7
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23255#discussion_r239926758
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -57,9 +57,11 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23255#discussion_r239922982
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -752,6 +752,17 @@ class InsertSuite extends QueryTest
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23253#discussion_r239890397
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2563,4 +2563,18 @@ class JsonSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239872296
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -235,6 +235,7 @@ public void writeEmptyIterator
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239860885
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -161,6 +161,10 @@ private void writeSortedFile(boolean
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239859088
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -161,6 +161,10 @@ private void writeSortedFile(boolean
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23245
Thank you all. Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23238
Thank you for adding this to the migration doc.
cc @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23238#discussion_r239708569
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -141,6 +141,8 @@ displayTitle: Spark SQL Upgrading Guide
- In Spark version 2.3
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239707130
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -562,4 +562,18 @@ public void testPeakMemoryUsed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23252#discussion_r239706529
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala
---
@@ -16,10
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23245
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239702595
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -562,4 +562,18 @@ public void testPeakMemoryUsed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239700056
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -968,6 +970,17 @@ predicted <- predict(model, df)
head(predic
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239697971
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -562,4 +562,18 @@ public void testPeakMemoryUsed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r239697860
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -562,4 +562,18 @@ public void testPeakMemoryUsed
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23250
Thank you, @HyukjinKwon . Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/23250
[SPARK-26298][BUILD] Upgrade Janino to 3.0.11
## What changes were proposed in this pull request?
This PR aims to upgrade Janino compiler to the latest version 3.0.11
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23159
cc @cloud-fan and @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r239365705
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSourceSuite.scala
---
@@ -32,6 +32,7 @@ import org.apache.spark.util.Utils
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r239365367
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
---
@@ -190,4 +192,103 @@ class HiveOrcSourceSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r239364631
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSourceSuite.scala
---
@@ -222,4 +223,66 @@ class HiveParquetSourceSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r239361792
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
---
@@ -73,9 +73,11 @@ class HiveOrcSourceSuite extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23213
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239259444
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -610,3 +616,58 @@ setMethod("write.ml", signature(object = "LDAModel"
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239258564
--- Diff: docs/ml-clustering.md ---
@@ -265,3 +265,44 @@ Refer to the [R API
docs](api/R/spark.gaussianMixture.html) for more details
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239258366
--- Diff: docs/ml-clustering.md ---
@@ -265,3 +265,44 @@ Refer to the [R API
docs](api/R/spark.gaussianMixture.html) for more details
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239257840
--- Diff: docs/ml-clustering.md ---
@@ -265,3 +265,44 @@ Refer to the [R API
docs](api/R/spark.gaussianMixture.html) for more details
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23239#discussion_r239256853
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -174,11 +174,6 @@ public static float getFloat(Object object, long
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23141#discussion_r239255684
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -165,10 +165,14 @@ public void
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239228923
--- Diff: examples/src/main/r/ml/powerIterationClustering.R ---
@@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239224970
--- Diff: docs/ml-clustering.md ---
@@ -265,3 +265,44 @@ Refer to the [R API
docs](api/R/spark.gaussianMixture.html) for more details
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239224498
--- Diff: docs/ml-clustering.md ---
@@ -265,3 +265,44 @@ Refer to the [R API
docs](api/R/spark.gaussianMixture.html) for more details
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239203950
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -610,3 +616,58 @@ setMethod("write.ml", signature(object = "LDAModel"
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239198848
--- Diff: R/pkg/tests/fulltests/test_mllib_clustering.R ---
@@ -319,4 +319,18 @@ test_that("spark.posterior and spark.perpl
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239197337
--- Diff: R/pkg/tests/fulltests/test_mllib_fpm.R ---
@@ -84,19 +84,21 @@ test_that("spark.fpGrowth", {
})
test_that("s
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23072#discussion_r239194803
--- Diff: R/pkg/R/mllib_clustering.R ---
@@ -610,3 +616,58 @@ setMethod("write.ml", signature(object = "LDAModel"
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23218
Thank you, @srowen , @HyukjinKwon , @shaneknapp !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23232
I merged all three PRs (2.4/2.3/2.2). Please close the PRs. :)
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23222
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23218
This might be https://bugs.openjdk.java.net/browse/JDK-8136447 (which is
resolved later by other issue)
```
$ grep build_loop_late_post consoleFull*
consoleFull.4451:# V
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23218
Surprisingly, all of three are due to consistent JVM crashes. It seems that
Scala 2.12.8 or Spark has some unstable code somewhere.
-
https://amplab.cs.berkeley.edu/jenkins/job
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238944485
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,82 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238944132
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2370,4 +2370,51 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238944067
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2370,4 +2370,51 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238944097
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2370,4 +2370,51 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238943983
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2370,4 +2370,51 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238943694
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
---
@@ -190,4 +190,12 @@ class HiveOrcSourceSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238943607
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2370,4 +2370,51 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238943270
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2370,4 +2370,51 @@ class HiveDDLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238804336
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2899,6 +2899,144 @@ class SQLQuerySuite extends QueryTest
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238803747
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
---
@@ -53,6 +55,133 @@ class ExplainSuite extends QueryTest
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238803424
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
---
@@ -53,6 +55,133 @@ class ExplainSuite extends QueryTest
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23210
@mgaido91 . This needs to land `branch-2.4/branch-2.3/branch-2.2`, but it
fails at `branch-2.4` due to the conflicts in the test case file. Could you
make separate backport PRs for each
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23218
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23218
Now, it's released. Let's try again.
-
http://central.maven.org/maven2/com/typesafe/genjavadoc/genjavadoc-plugin_2.12.8/0.11
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238524452
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23155#discussion_r238521078
--- Diff: docs/running-on-kubernetes.md ---
@@ -932,15 +935,31 @@ specific to Spark on Kubernetes.
(none)
Specify the local
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23155#discussion_r238521043
--- Diff: docs/running-on-kubernetes.md ---
@@ -932,15 +935,31 @@ specific to Spark on Kubernetes.
(none)
Specify the local
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23155#discussion_r238521015
--- Diff: docs/running-on-kubernetes.md ---
@@ -932,15 +935,31 @@ specific to Spark on Kubernetes.
(none)
Specify the local
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23155#discussion_r238520981
--- Diff: docs/running-on-kubernetes.md ---
@@ -932,15 +935,31 @@ specific to Spark on Kubernetes.
(none)
Specify the local
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23155
Oh, I thought it could be handled by another Kubernetes committers. I'll
take a look again.
---
-
To unsubscribe, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23210
LGTM except one minor comment about a new test case.
Ping, @gatorsmile and @cloud-fan . Could you review this PR? This is to fix
a correctness issue
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23210#discussion_r238424196
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1647,6 +1647,15 @@ class DatasetSuite extends QueryTest
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23178#discussion_r238113456
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -38,114 +38,106 @@ import
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23178#discussion_r238007506
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -38,114 +38,106 @@ import
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23178#discussion_r238007219
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -38,114 +38,106 @@ import
1 - 100 of 7331 matches
Mail list logo
