Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22707#discussion_r240073151
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -774,4 +774,23 @@ class InsertSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22707#discussion_r240002357
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -227,18 +227,22 @@ case class InsertIntoHiveTable
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22707#discussion_r239997805
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -774,4 +774,23 @@ class InsertSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22707#discussion_r239996822
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -774,4 +774,23 @@ class InsertSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22707#discussion_r239996528
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -774,4 +774,23 @@ class InsertSuite extends QueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22707
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23259#discussion_r239994423
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -769,7 +774,7 @@ nonReserved
| REVOKE | GRANT | LOCK
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23259
To discuss this topic smoothly, I made this pr.
Any comment/suggestion is welcome.
cc: @gatorsmile @cloud-fan @viirya
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/23259
[SPARK-26215][SQL][WIP] Define reserved/non-reserved keywords based on the
ANSI SQL standard
## What changes were proposed in this pull request?
This pr targeted to define reserved/non-reserved
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23258#discussion_r239993889
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -182,10 +182,13 @@ class SQLMetricsSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23258#discussion_r239993718
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -182,10 +182,13 @@ class SQLMetricsSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23258#discussion_r239993561
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -26,7 +26,7 @@ import org.apache.spark.SparkFunSuite
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23258
cc: @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22141
nvm ;) we still have much time until the next release.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23206
What's a concrete example? IMHO the current proposed API is some
complicated/cumbersome to users and I feel its error-prone
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22141
Any update?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21777
@kiszk Can you close this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
Anyway, if we can accept the additional test time, I think it is the best
to run the tests on all the 4 patterns above for strict checks
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23206
cc: @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23206
The current post hook is not enough for the use case you assume?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
In short, we need to run the tests on the three patterns below, right?
- wholeStage=true, factoryMode=CODEGEN_ONLY (default behaviour in Spark)
- wholeStage=false, factoryMode=CODEGEN_ONLY
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
yea, I think they're not totally the same..., but I'm not sure that the
test run (`wholeStage=false, factoryMode=CODE_ONLY`) is worth the time cost
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
Sorry, my bad; it was longer than the current master by ~2 times. That's
because the current master has already run two config set patterns
(`wholeStage=true,factoryMode=CODEGEN_ONLY
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
yea, it seems its longer by ~4 times;
```
23:25:43.880 WARN org.apache.spark.sql.SQLQueryTestSuite:
=== Codegen/Interpreter Time Metrics ===
Total time: 602.64531157 seconds
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
I'm looking into that now ;) Just give me more time to check.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238905795
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
---
@@ -53,6 +55,133 @@ class ExplainSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238899777
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2899,6 +2899,144 @@ class SQLQuerySuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238895286
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -144,9 +144,10 @@ class SQLQueryTestSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238894837
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,98 @@ class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23194
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238630406
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2899,6 +2899,144 @@ class SQLQuerySuite extends QueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
yea, its similar, but I personally think its orthogonal to SPARK-24562.
This pr only targets a default config set for codegen-only and interpreter mode
tests
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238625915
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -144,9 +144,10 @@ class SQLQueryTestSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23213#discussion_r238625477
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2899,6 +2899,144 @@ class SQLQuerySuite extends QueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
cc: @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
cc: @cloud-fan @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22468
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238543369
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,98 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238530264
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -535,4 +535,100 @@ class
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/23213
[SPARK-26262][SQL] Run SQLQueryTestSuite with
WHOLESTAGE_CODEGEN_ENABLED=false
## What changes were proposed in this pull request?
For better test coverage, this pr set `false
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23194
LGTM except for minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23194#discussion_r238526892
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -377,41 +377,41 @@ abstract class DDLSuite extends QueryTest
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/23212
[SPARK-25498][SQL][FOLLOW-UP] Return an empty config set when regenerating
the golden files
## What changes were proposed in this pull request?
This pr is to return an empty config set when
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23212
cc: @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22468#discussion_r238490121
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -157,4 +157,22 @@ object InternalRow
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r238489997
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -148,12 +156,25 @@ class SQLQueryTestSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23194#discussion_r238256775
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -439,31 +440,22 @@ abstract class DDLSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23194#discussion_r238256611
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -377,41 +377,42 @@ abstract class DDLSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23194#discussion_r238256563
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -377,41 +377,42 @@ abstract class DDLSuite extends QueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22318
In the example @viirya described above
(https://github.com/apache/spark/pull/22318#issuecomment-426317617), I think
the interpretation is unclear to most users and I'm fairly concerned
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23094#discussion_r238239581
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -87,11 +87,32 @@ abstract class JdbcDialect extends Serializable
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23094#discussion_r238239195
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -87,11 +87,32 @@ abstract class JdbcDialect extends Serializable
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23094#discussion_r238232050
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -87,11 +87,32 @@ abstract class JdbcDialect extends Serializable
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23094
Also, can you add tests in MySQLIntegrationSuite, too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23094
@golovan thanks for your work. Can you make the title complete (... -> for
table names)?
---
-
To unsubscribe, e-mail: revi
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23094
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22468
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22204
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r238177033
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -148,12 +156,21 @@ class SQLQueryTestSuite extends QueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r238176184
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala
---
@@ -64,7 +85,7 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r238175630
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -148,12 +156,21 @@ class SQLQueryTestSuite extends QueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22204
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r238152087
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -335,6 +335,12 @@ object SQLConf {
.booleanConf
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r238151565
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala
---
@@ -64,7 +85,7 @@ class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22999
This is only the Oracle dialect issue? How about other dialects?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22318
@peter-toth we cannot fix the issue of the description without changing
[the existing
behaviour](https://github.com/apache/spark/pull/22318#issuecomment-426317617
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23032
We cannot fix the root cause in `GenerateUnsafeProjection.createCode()`? I
think, since we don't check if all the mutable variables are used in gen'd
code, the similar issue can easily happen
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/23199#discussion_r238130900
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -1045,6 +1046,11 @@ DOUBLE_LITERAL
| DECIMAL_DIGITS
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22512
Yea, I'll update in a few days.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22512
I'm looking into the failure reason... (passed in the local, but failed in
the jenkins...)
---
-
To unsubscribe, e-mail: reviews
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227626505
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MutableProjectionSuite.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227626456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -143,4 +144,25 @@ object InternalRow {
case u
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21860
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21860
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21860
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22755
It looks good to improve the test coverage. But, it seems to be hard to
wrap all the test case with `withSQLConf`. So, how about adding a helper
function for turning off/on codegen
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17174
@dongjoon-hyun Thanks for your checks!! I still wait for other developer's
feedbacks. If the approach is positive, I'll make a pr. Also, welcome another
idea to solve this. cc: @gatorsmile
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227609747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -143,4 +144,24 @@ object InternalRow {
case u
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227609600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -143,4 +144,24 @@ object InternalRow {
case u
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227226902
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -140,6 +141,14 @@ class SQLQueryTestSuite extends QueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22512
ok, I'll add tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227224209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala
---
@@ -49,10 +51,54 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227224030
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala
---
@@ -49,10 +51,54 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22755#discussion_r227215773
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
---
@@ -122,19 +122,22 @@ class ExistenceJoinSuite extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22755
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22778#discussion_r227215135
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -33,23 +34,44 @@ class RewriteSubquerySuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22778#discussion_r227214593
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -33,23 +34,44 @@ class RewriteSubquerySuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22778#discussion_r227214404
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -33,23 +34,44 @@ class RewriteSubquerySuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22778#discussion_r227205054
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -33,23 +34,44 @@ class RewriteSubquerySuite
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22778
Also, to make sure no performance regression in the optimizer, can you
check optimizer statistics in TPCDS by running `TPCDSQuerySuite`, too
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22778
Can you put the concrete example of the missing case you described in the
PR description?
---
-
To unsubscribe, e-mail: reviews
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22712#discussion_r227201626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala
---
@@ -53,6 +53,10 @@ class InterpretedOrdering(ordering
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22219
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
1 - 100 of 3605 matches
Mail list logo
