Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21403
sure, feel free to open a PR first.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
oh, I see @cloud-fan. But, IIUC, the other one is not used anymore. The
only reference was removed by 4ce970d71488c7de6025ef925f75b8b92a5a6a79. I'll
submit a PR to remove it if you agree.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21403
I just realized there are 2 `InSubquery` expressions, seems we need to
rename one of it. @mgaido91 any ideas?
---
-
To
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
@cloud-fan sure, I'll create a followup PR, thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21403
ah i see. Can you add it to the migration guide? We need to tell users what
will break after upgrading to 2.4 and why.
---
-
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
@cloud-fan, no, it introduces a behavior change when structs are involved.
The two queries
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21403
I'm writing release notes, and this one gets my attention. @mgaido91 can
you confirm that this patch doesn't introduce any behavior change? i.e. if it
fails previously, it still fails. If it
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21403
LGTM, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94292/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94292 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94292/testReport)**
for PR 21403 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94292 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94292/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94281/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94281 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94281/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94281/testReport)**
for PR 21403 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94269/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94269 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94269/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94269 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94269/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94202/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94202/testReport)**
for PR 21403 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94202/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21403
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94178/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94178 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94178/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94178 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94178/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94156/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94156 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94156/testReport)**
for PR 21403 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94156 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94156/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94129/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94129/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94129/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93999/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93999 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93999/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94001/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94001 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94001/testReport)**
for PR 21403 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #94001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94001/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93999 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93999/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21403
Had a related discussion with @marmbrus a few months ago. He also does not
like reusing `IN` expression for subquery processing. I think it makes sense to
introduce `InSubquery` expressions for
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
no, sorry, you're right. In the case when it is not a subquery, it is safe
to treat them as the same. I got confused checking the result of other DBs as
they are all behaving differently in that
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21403
The example of non-sub-query looks weird. If `where col1 in ((1, 'a'))`
can't work, what is the right query if we do have a struct type column?
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
@cloud-fan the problem is that the change is not only for the case when IN
is followed by a listquery. The change is needed also in the other case. And
the reason why this change is needed is to
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21403
I'd like to avoid changing the signature of an existing expression if
possible. It's not public so we can change it, but I believe some advanced
users use these internal classes and we should
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93783/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93783 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93783/testReport)**
for PR 21403 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93783 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93783/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
any more comments on this @cloud-fan @gatorsmile @maryannxue ?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93670/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93670 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93670/testReport)**
for PR 21403 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93670 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93670/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93599/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93599 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93599/testReport)**
for PR 21403 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21403
`case class In(value: Expression, list: Seq[Expression])` is an internal
class. We do not expect user applications rely on the internal data structure.
If they did, they should understand the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93599 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93599/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21403
@maryannxue as I said my initial proposal was like that. I think that this
has the advantage of avoiding some code duplication as the same logic which is
added in ResolveInValues has to be spread
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21403
@mgaido91 I see. But by using Seq[Expression] in `In`, can we hopefully
remove `ResolveInValues`. I wouldn't mind changing the parser if it's necessary
and if it saves work elsewhere. Having
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93543/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93543 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93543/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93539/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93539 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93539/testReport)**
for PR 21403 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21403
**[Test build #93543 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93543/testReport)**
for PR 21403 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21403
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
1 - 100 of 156 matches
Mail list logo
