Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
these 3 combinations LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99762/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99762 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99762/testReport)**
for PR 23213 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23213
@maropu I'd say so, but I am still not sure what (if there is one) is the
difference between `wholeStage=false,sactoryMode=NO_CODEGEN` and
`wholeStage=true,factoryMode=NO_CODEGEN`.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99762/testReport)**
for PR 23213 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23213
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99756/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99756 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99756/testReport)**
for PR 23213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99756 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99756/testReport)**
for PR 23213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99750/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99750 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99750/testReport)**
for PR 23213 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
Anyway, if we can accept the additional test time, I think it is the best
to run the tests on all the 4 patterns above for strict checks.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23213
I think so, don't know if @cloud-fan or @mgaido91 has other opinions?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99750 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99750/testReport)**
for PR 23213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
In short, we need to run the tests on the three patterns below, right?
- wholeStage=true, factoryMode=CODEGEN_ONLY (default behaviour in Spark)
- wholeStage=false, factoryMode=CODEGEN_ONLY
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23213
`wholeStage=false, factoryMode=CODE_ONLY` and `wholeStage=false,
factoryMode=NO_CODEGEN` should have more complete test coverage for
`GenerateUnsafeProject`, `GenerateMutableProject`, etc.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
If we look at test coverage, `wholeStage=false, factoryMode=CODE_ONLY` will
go through code paths that wholeStageCodegen doesn't cover. Or did I miss
something?
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
But whole stage codegen will not test `GenerateUnsafeProject`,
`GenerateMutableProject`, etc., right?
---
-
To unsubscribe,
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
yea, I think they're not totally the same..., but I'm not sure that the
test run (`wholeStage=false, factoryMode=CODE_ONLY`) is worth the time cost.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
how about `wholeStage=false, factoryMode=CODE_ONLY`? I think it's different
from `wholeStage=false, factoryMode=NO_CODEGEN`.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23213
Yes, I am wondering too: which is the difference between:
`spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=NO_CODEGEN`
and
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
Sorry, my bad; it was longer than the current master by ~2 times. That's
because the current master has already run two config set patterns
(`wholeStage=true,factoryMode=CODEGEN_ONLY` and
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
that's a lot of time...
Can we think more about the combination of codegen and wholeStage? When we
turn on whole stage codegen but turn off codegen, what will happen?
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
yea, it seems its longer by ~4 times;
```
23:25:43.880 WARN org.apache.spark.sql.SQLQueryTestSuite:
=== Codegen/Interpreter Time Metrics ===
Total time: 602.64531157 seconds
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
I'm looking into that now ;) Just give me more time to check.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
do you know how long `SQLQueryTestSuite` takes? We are making it longer by
4 times here, so better to know the overhead.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99692/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99692 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99692/testReport)**
for PR 23213 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23213
**[Test build #99692 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99692/testReport)**
for PR 23213 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23213
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
42 matches
Mail list logo
