Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/18323
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130526899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,124 @@ case class BRound(child:
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130526538
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,124 @@ case class BRound(child:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130038008
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,124 @@ case class BRound(child:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130037738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,124 @@ case class BRound(child:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130036804
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -631,3 +632,109 @@ abstract class TernaryExpression
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130036608
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,124 @@ case class BRound(child:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130036586
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,124 @@ case class BRound(child:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130035216
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,124 @@ case class BRound(child:
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r130021930
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1219,44 +1219,91 @@ case class WidthBucket(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r128569724
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,77 @@ case class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r128482157
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r128482031
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127614336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127614328
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127614121
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,51 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127613839
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
---
@@ -644,4 +645,37 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127613829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127613753
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,51 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127613668
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,51 @@ case class
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127601368
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,51 @@ case class BRound(child:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127595777
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,51 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r127595711
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,51 @@ case class
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123941530
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/MathUtilsSuite.scala
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123937970
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/MathUtilsSuite.scala
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123936383
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/MathUtilsSuite.scala
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123934820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123930006
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123918251
--- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql ---
@@ -92,3 +92,8 @@ select abs(-3.13), abs('-2.19');
-- positive/negative
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123918240
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123919502
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123919350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123677893
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123677056
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123408655
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,51 @@ case class BRound(child:
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123409892
--- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql ---
@@ -92,3 +92,8 @@ select abs(-3.13), abs('-2.19');
-- positive/negative
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123401825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -631,3 +631,109 @@ abstract class TernaryExpression
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123410671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123411306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123411090
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123410649
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123402665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -631,3 +631,109 @@ abstract class TernaryExpression
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123408856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123409716
--- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql ---
@@ -92,3 +92,8 @@ select abs(-3.13), abs('-2.19');
-- positive/negative
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123410449
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123412204
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/MathUtilsSuite.scala
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123409299
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
---
@@ -644,4 +645,36 @@ class
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123401878
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -631,3 +631,109 @@ abstract class TernaryExpression
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/18323
[SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET
## What changes were proposed in this pull request?
Add build-in SQL function - `WIDTH_BUCKET`
Ref:
49 matches
Mail list logo
