Github user woodthom2 closed the pull request at:
https://github.com/apache/spark/pull/21828
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21828#discussion_r204012751
--- Diff: python/pyspark/ml/regression.py ---
@@ -1116,7 +1116,7 @@ def setParams(self, featuresCol="features",
labelCol="label", predictionCol="pre
Github user woodthom2 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21828#discussion_r203997163
--- Diff: python/pyspark/ml/regression.py ---
@@ -1116,7 +1116,7 @@ def setParams(self, featuresCol="features",
labelCol="label", predictionCol="pre
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21828#discussion_r203995996
--- Diff: python/pyspark/ml/regression.py ---
@@ -1116,7 +1116,7 @@ def setParams(self, featuresCol="features",
labelCol="label", predictionCol="pre
Github user woodthom2 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21828#discussion_r203994440
--- Diff: python/pyspark/ml/regression.py ---
@@ -1116,7 +1116,7 @@ def setParams(self, featuresCol="features",
labelCol="label", predictionCol="pre
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21828#discussion_r203994108
--- Diff: python/pyspark/ml/regression.py ---
@@ -1116,7 +1116,7 @@ def setParams(self, featuresCol="features",
labelCol="label", predictionCol="pre
GitHub user woodthom2 opened a pull request:
https://github.com/apache/spark/pull/21828
Update regression.py
Correct typo impuriy -> impurity
(this would have stopped GBT working for some hyperparameter configurations)
## What changes were proposed in this pull request?
